Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No offers should be accepted after zcf.shutdown() #1756

Closed
katelynsills opened this issue Sep 14, 2020 · 0 comments · Fixed by #1772
Closed

No offers should be accepted after zcf.shutdown() #1756

katelynsills opened this issue Sep 14, 2020 · 0 comments · Fixed by #1772
Assignees
Labels
bug Something isn't working Zoe package: Zoe

Comments

@katelynsills
Copy link
Contributor

What is the Problem Being Solved?

Currently, E(zoe).offer() does not throw after zcf.shutdown() is called. However, it should throw so that no more offers are accepted.

test.failing(`zcf.shutdown - no further offers accepted`, async t => {
  const { zoe, zcf } = await setupZCFTest({});
  const invitation = await zcf.makeInvitation(() => {}, 'seat');
  zcf.shutdown();
  await t.throwsAsync(() => E(zoe).offer(invitation), {
    message: 'No further offers are accepted',
  });
});
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Zoe package: Zoe
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant