fix: simplify autoswap helper APIs #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katelynsills
approved these changes
Sep 10, 2020
dtribble
force-pushed
the
autoswap-positional-helpers
branch
2 times, most recently
from
b4943ac to
8333a4e
Compare
Chris-Hibbert
approved these changes
Sep 11, 2020
|
@dtribble Can we merge this? I can help get it merged by doing the rebasing if that would be helpful. |
|
Apologies. I thought that the merge had happened. Yes please take it over. |
Switch the calling convention for autoswap helpers to passing positional arguments. The use of a params object doesn't work very well in JS. It's exacerbated if we need to use `harden`, and the value is reduced now that we have pervasive types on helpers.
katelynsills
force-pushed
the
autoswap-positional-helpers
branch
from
8333a4e to
749bc64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the calling convention for autoswap helpers to
passing positional arguments. The use of a params object
doesn't work very well in JS. It's exacerbated if we
need to use
harden, and the value is reduced now thatwe have pervasive types on helpers.
Given that, please consider this approach.