Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use REMOTE_STYLE rather than 'presence' to prepare #1577

Merged
merged 1 commit into from
Aug 30, 2020
Merged

Conversation

erights
Copy link
Member

@erights erights commented Aug 21, 2020

Currently, the passStyleOf(remotable) is 'presence', which mixes abstraction levels. It should be 'remote'. To prepare to make this change, @michaelfig introduced the REMOTE_STYLE global constant whose current value is 'presence'. However, we still had the literal 'presence' string scattered throughout our code. This replaces all those with the REMOTE_STYLE constant until we have made the transition.

I verified that, in the PR, if we set the constant to 'remote' CI still passes. However, we do not intend to actually take this step at this time. This PR is just to prepare.

@erights erights requested a review from michaelfig August 21, 2020 02:56
@erights erights marked this pull request as ready for review August 21, 2020 03:39
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please rebase and merge at your convenience.

@erights erights merged commit 6b97ae8 into master Aug 30, 2020
@erights erights deleted the remote-style branch August 30, 2020 23:21
@warner
Copy link
Member

warner commented Aug 31, 2020

The swingset tests were using 'presence' as a mode flag, unrelated to anything within marshal.js. @erights is going to revert those changes.

erights added a commit that referenced this pull request Aug 31, 2020
@erights
Copy link
Member Author

erights commented Aug 31, 2020

The swingset tests were using 'presence' as a mode flag, unrelated to anything within marshal.js. @erights is going to revert those changes.

At #1647

erights added a commit that referenced this pull request Aug 31, 2020
* fix: revert overspill from PR #1577
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants