fix: need type decl for HandledPromise.reject #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
reviewed
Aug 9, 2020
There was a problem hiding this comment.
interface HandledPromiseConstructor extends PromiseConstructor { ... works for me. Perhaps that's what you're looking for?
https://www.typescriptlang.org/docs/handbook/interfaces.html#extending-interfaces
|
That's what I needed. Fixed. Thanks. |
|
Do you want also to fix #1362 while you're there? |
Could you remove the explicit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declared the
HandledPromiseconstructor to extend from thePromiseconstructor, mirroring the implementation's inheritance arrangement. Thus, theHandledPromisenow inherits therejectdeclaration. Also theresolvedeclaration, which this PR deletes.Better typing of
E.when, fixing the "when" component of #1362 .