Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ERef<T> is T | PromiseLike<T> #1383

Merged
merged 1 commit into from
Aug 6, 2020
Merged

fix: ERef<T> is T | PromiseLike<T> #1383

merged 1 commit into from
Aug 6, 2020

Conversation

erights
Copy link
Member

@erights erights commented Aug 6, 2020

@erights erights requested a review from michaelfig August 6, 2020 05:45
@erights erights mentioned this pull request Aug 6, 2020
Closed
michaelfig
michaelfig reviewed Aug 6, 2020
View reviewed changes
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref is a little vague. Would you instead consider making it ERef, to designate an eventual reference?

@michaelfig michaelfig self-requested a review August 6, 2020 06:37
michaelfig
michaelfig approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM!

@erights erights changed the title fix: Ref<T> is T | PromiseLike<T> fix: ERef<T> is T | PromiseLike<T> Aug 6, 2020
@erights
Copy link
Member Author

erights commented Aug 6, 2020

ERef it is. Thanks!

@erights erights force-pushed the ref-type-constructor branch from d9442e7 to 1c8abc9 Compare August 6, 2020 07:15
@erights
Copy link
Member Author

erights commented Aug 6, 2020

Everything passed except one mysterious error under appveyor that clearly has nothing to do with this PR. So merging anyway.

@erights erights merged commit 8ef4d66 into master Aug 6, 2020
@erights erights deleted the ref-type-constructor branch August 6, 2020 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelfig michaelfig michaelfig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erights @michaelfig