fix: remove obsolete "unwrap" #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
commented
Aug 3, 2020
| @@ -51,7 +51,7 @@ export function makeHandledPromise(Promise) { | |||
| let presenceToHandler; | |||
| let presenceToPromise; | |||
| let promiseToUnsettledHandler; | |||
| let promiseToPresence; // only for HandledPromise.unwrap | |||
| let promiseToPresence; | |||
There was a problem hiding this comment.
That old comment was correct when written. But trying to remove promiseToPresence reveals that it has since grown another use --- in shortening.
erights
commented
Aug 3, 2020
| @@ -33,8 +33,6 @@ export function producePromise() { | |||
| /** @type {(reason: any) => void} */ | |||
| let rej = NOOP_INITIALIZER; | |||
|
|
|||
| // We use a HandledPromise so that we can run HandledPromise.unwrap(p) | |||
| // even if p doesn't travel through a comms system (like SwingSet's). | |||
| const p = new HandledPromise((resolve, reject) => { | |||
There was a problem hiding this comment.
Even without that rationale, I still prefer HandledPromise and so left the code alone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1361