Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ERTP): rename extent to value #1306

Merged
merged 2 commits into from
Jul 20, 2020
Merged

refactor(ERTP): rename extent to value #1306

merged 2 commits into from
Jul 20, 2020

Conversation

katelynsills
Copy link
Contributor

Rename extent to value

Closes #1293

@katelynsills katelynsills added the ERTP package: ERTP label Jul 17, 2020
@katelynsills katelynsills added this to the ertp-v0.7.0 milestone Jul 17, 2020
@katelynsills katelynsills self-assigned this Jul 17, 2020
@katelynsills katelynsills changed the base branch from master to ertp-v0.7.0 July 17, 2020 23:59
@katelynsills
Copy link
Contributor Author

Got a verbal approval from @erights this morning

erights
erights approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup LGTM

@katelynsills katelynsills merged commit 8630e8e into ertp-v0.7.0 Jul 20, 2020
@katelynsills katelynsills deleted the 1293-rename-extent branch July 20, 2020 20:11
@katelynsills katelynsills mentioned this pull request Jul 20, 2020
Merged
katelynsills added a commit that referenced this pull request Jul 21, 2020
@katelynsills
refactor(ERTP): rename extent to value (#1306)
35f2b2c 
* refactor(ERTP): rename extent to value
katelynsills added a commit that referenced this pull request Jul 21, 2020
@katelynsills
refactor(ERTP): rename extent to value (#1306)
be112cc 
* refactor(ERTP): rename extent to value
katelynsills added a commit that referenced this pull request Jul 21, 2020
@katelynsills
feat: ERTP v0.7.0 (#1317)
2d66b5a 
* feat(ERTP): rename `extent` to `value` (#1306)

* feat(ERTP): rename `produceIssuer` to `makeIssuerKit` (#1305)
@katelynsills katelynsills mentioned this pull request Jul 24, 2020
Closed
@kriskowal
Copy link
Member

I like the results a lot. Thanks for taking my feedback into consideration!

@katelynsills
Copy link
Contributor Author

I like the results a lot. Thanks for taking my feedback into consideration!

Thanks so much for the feedback! I think it reads much better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chris-Hibbert Chris-Hibbert Chris-Hibbert approved these changes

@erights erights erights approved these changes

Assignees

@katelynsills katelynsills

Labels
ERTP package: ERTP
Projects
None yet
Milestone
ertp-v0.7.0
Development

Successfully merging this pull request may close these issues.

[ERTP] Rename extent to value
4 participants
@katelynsills @kriskowal @erights @Chris-Hibbert