Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: temporary fix to support displaying NFT extents which are arrays of objects #1094

Merged
merged 1 commit into from
May 11, 2020

Conversation

katelynsills
Copy link
Contributor

@katelynsills katelynsills commented May 11, 2020

This is meant to be a very temporary fix to display something (and not break) when the wallet is holding NFT which have arrays of objects as extents. In the very near future, we will need to change this to take the dehydrated extent which has slots for petnames and do something to display petnames in a special format.

Closes #1088

Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I acknowledge the temporary nature of these fixes. Looking forward to the petname stuff.

@katelynsills katelynsills merged commit 07e554b into master May 11, 2020
@katelynsills katelynsills deleted the 1088-display-nft-extent branch May 11, 2020 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wallet-frontend] Non-fungible extent causes React error
2 participants