You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With #10588, srcChain (holdingChain) is a new parameter required for the ChainHub.getAsset() lookup. This is because denoms are only unique in the context of a single chain.
For convenience, the Chain objects (RemoteChainFacade, LocalChainFacade) should also have a getAsset method, but not require srcChain. Each chain knows the correct parameter to pass to chainHub.getAsset().
Description of the Design
add .getAsset() to RemoteChainFacade, LocalChainFacade
add getDenomInfo() to RemoteChainFacade, LocalChainFacade
TODO: confirm both are needed or just one. getDenomInfo returns chainInfos, where getAsset returns chainNames
Security Considerations
Scaling Considerations
Test Plan
Upgrade Considerations
The text was updated successfully, but these errors were encountered:
What is the Problem Being Solved?
With #10588,
srcChain
(holdingChain) is a new parameter required for theChainHub.getAsset()
lookup. This is because denoms are only unique in the context of a single chain.For convenience, the
Chain
objects (RemoteChainFacade
,LocalChainFacade
) should also have agetAsset
method, but not requiresrcChain
. Each chain knows the correct parameter to pass tochainHub.getAsset()
.Description of the Design
.getAsset()
to RemoteChainFacade, LocalChainFacadegetDenomInfo()
to RemoteChainFacade, LocalChainFacadegetDenomInfo
returns chainInfos, wheregetAsset
returns chainNamesSecurity Considerations
Scaling Considerations
Test Plan
Upgrade Considerations
The text was updated successfully, but these errors were encountered: