Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chain objects should have an asset lookup helper #10601

Open
2 tasks
0xpatrickdev opened this issue Dec 2, 2024 · 0 comments
Open
2 tasks

Chain objects should have an asset lookup helper #10601

0xpatrickdev opened this issue Dec 2, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@0xpatrickdev
Copy link
Member

What is the Problem Being Solved?

With #10588, srcChain (holdingChain) is a new parameter required for the ChainHub.getAsset() lookup. This is because denoms are only unique in the context of a single chain.

For convenience, the Chain objects (RemoteChainFacade, LocalChainFacade) should also have a getAsset method, but not require srcChain. Each chain knows the correct parameter to pass to chainHub.getAsset().

Description of the Design

  • add .getAsset() to RemoteChainFacade, LocalChainFacade
  • add getDenomInfo() to RemoteChainFacade, LocalChainFacade
    • TODO: confirm both are needed or just one. getDenomInfo returns chainInfos, where getAsset returns chainNames

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations

@0xpatrickdev 0xpatrickdev added the enhancement New feature or request label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant