Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote Counter should use greater than logic #10274

Closed
otoole-brendan opened this issue Oct 15, 2024 · 0 comments · Fixed by #10306
Closed

Vote Counter should use greater than logic #10274

otoole-brendan opened this issue Oct 15, 2024 · 0 comments · Fixed by #10306
Assignees

Comments

@otoole-brendan
Copy link
Contributor

otoole-brendan commented Oct 15, 2024

EC committee vote quorum is supposed to be greater than 50% by design i.e. 4/6 or 2/3. Per the code - this is not the case and it's actually 3/6. This is a bug and should be fixed such that quorum for any future committee requires greater than 50% of votes

Per @Chris-Hibbert:

case QuorumRule.MAJORITY:
return ceilDivide(committeeSize, 2);

ceilDivide: (x, y) => {
y = Nat(y);
return Nat(Nat(x) + y - 1n) / y;
}

I'm wrong. The use of Nat there cause half to be enough for even numbers. But with three it does the right thing. I think that should be a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants