Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install contractGovernor only once in priceFeed replacement proposal #10248

Open
Chris-Hibbert opened this issue Oct 9, 2024 · 0 comments · May be fixed by #10256
Open

Install contractGovernor only once in priceFeed replacement proposal #10248

Chris-Hibbert opened this issue Oct 9, 2024 · 0 comments · May be fixed by #10256
Assignees
Labels
contract-upgrade enhancement New feature or request Governance Governance oracle Related to on-chain oracles.

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

@dckc pointed out that #10163 was installing the contractGovernor twice. I don't think this will break anything, but it will make verifying the connectivity of the governance components more difficult.

Description of the Design

Install it once in whichever proposal will run first, and pass it to the other proposals via a new (temporary) name in the promiseSpace. If not passed sub rosa like this, the second proposal would probably get the previous value, since the promise has already been resolved.

Security Considerations

This affects legibility of the governed contracts.

Scaling Considerations

inconsequential.

Test Plan

Ensure that the two installations are the same.

Upgrade Considerations

This is not required to be included with the priceFeed update (#10074), but it would be nice.
It has its impact during upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contract-upgrade enhancement New feature or request Governance Governance oracle Related to on-chain oracles.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant