You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have JS code strewn about that spawns a process to call agoric or agops on the CLI. Since those are themselves implemented in JS, that's an unnecessary hop. Having it requires duplicating lots of logic, requires transforming all JS types to and from CLI arguments, and creates opportunities for bugs.
Create a module that provides those functions directly from agoric-cli. It can be a subpath export of the package.
Alternately there could be a new package like agoric-commands that agoric-cli uses, but I think that's unnecessary separation. packages/agoric-cli provides the agoric package which has bin paths but can also provide module exports.
What is the Problem Being Solved?
We have JS code strewn about that spawns a process to call
agoric
oragops
on the CLI. Since those are themselves implemented in JS, that's an unnecessary hop. Having it requires duplicating lots of logic, requires transforming all JS types to and from CLI arguments, and creates opportunities for bugs.Description of the Design
Look at https://github.com/Agoric/agoric-3-proposals/blob/main/packages/synthetic-chain/src/lib/cliHelper.ts
Create a module that provides those functions directly from agoric-cli. It can be a subpath export of the package.
Alternately there could be a new package like
agoric-commands
that agoric-cli uses, but I think that's unnecessary separation.packages/agoric-cli
provides theagoric
package which has bin paths but can also provide module exports.This could also help with,
Security Considerations
Execution would run in the single JS process instead of spawning.
Scaling Considerations
n/a
Test Plan
Usages in a3p-integration
Upgrade Considerations
n/a
The text was updated successfully, but these errors were encountered: