fix: add a test and correct the collateral check

Agoric · Jan 29, 2021 · f692a00 · f692a00
1 parent 07e763d
commit f692a00
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/packages/zoe/src/contracts/loan/borrow.js b/packages/zoe/src/contracts/loan/borrow.js
@@ -55,9 +55,7 @@ export const makeBorrowInvitation = (zcf, config) => {
     // Assert the required collateral was escrowed.
     assert(
       loanMath.isGTE(
-        loanMath.make(
-          natSafeMath.multiply(collateralPriceInLoanBrand.value, 100),
-        ),
+        loanMath.make(collateralPriceInLoanBrand.value),
         mmr.scale(loanWanted),
       ),
       details`The required margin is approximately ${approxForMsg.value}% but collateral only had value of ${collateralPriceInLoanBrand.value}`,

diff --git a/packages/zoe/test/unitTests/contracts/loan/test-borrow.js b/packages/zoe/test/unitTests/contracts/loan/test-borrow.js
@@ -346,6 +346,19 @@ test('getDebtNotifier with interest', async t => {
   });
 });
 
+test('borrow collateral just too low', async t => {
+  const { borrowSeat: borrowSeatGood } = await setupBorrowFacet(75);
+  const offerResult = await E(borrowSeatGood).getOfferResult();
+  const collateralAmount = await E(offerResult).getRecentCollateralAmount();
+  t.is(collateralAmount.value, 75);
+
+  const { borrowSeat: borrowSeatBad } = await setupBorrowFacet(74);
+  await t.throwsAsync(() => E(borrowSeatBad).getOfferResult(), {
+    message:
+      'The required margin is approximately (a number)% but collateral only had value of (a number)',
+  });
+});
+
 test.todo('borrow bad proposal');
 
 test.todo('schedule a liquidation that fails, giving collateral to the lender');