chore: assert currentBalance greater than or equal to amount to be wi…

…thdrawn
Agoric · Sep 10, 2021 · c7fa39a · c7fa39a
1 parent 71aaf84
commit c7fa39a
Showing 1 changed file with 5 additions and 15 deletions.
diff --git a/packages/ERTP/src/paymentLedger.js b/packages/ERTP/src/paymentLedger.js
@@ -291,21 +291,11 @@ export const makePaymentLedger = (
    */
   const withdraw = (currentBalance, updatePurseBalance, amount) => {
     amount = coerce(amount);
-    let newPurseBalance;
-    try {
-      newPurseBalance = subtract(currentBalance, amount);
-    } catch (err) {
-      if (err instanceof RangeError) {
-        const withdrawalError = Error(
-          // @ts-ignore `X` (aka `details`) lazily constructs a
-          // string, but the types do not reflect that
-          X`Withdrawal of ${amount} failed because the purse only contained ${currentBalance}`,
-        );
-        assert.note(withdrawalError, X`Caused by: ${err}`);
-        throw withdrawalError;
-      }
-      throw err;
-    }
+    assert(
+      AmountMath.isGTE(currentBalance, amount),
+      X`Withdrawal of ${amount} failed because the purse only contained ${currentBalance}`,
+    );
+    const newPurseBalance = subtract(currentBalance, amount);
 
     const payment = makePayment(allegedName, brand);
     try {