Skip to content

Commit

Permalink
fix: address PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
michaelfig committed Dec 10, 2019
1 parent 503f8b8 commit b9ed6b5
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 7 deletions.
2 changes: 1 addition & 1 deletion packages/agoric-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"dependencies": {
"@agoric/bundle-source": "^1.0.3",
"@agoric/captp": "^1.2.0",
"@agoric/evaluate": "^2.1.3",
"@agoric/evaluate": "^2.2.0",
"@agoric/eventual-send": "^0.5.0",
"chalk": "^2.4.2",
"esm": "^3.2.5",
Expand Down
2 changes: 1 addition & 1 deletion packages/default-evaluate-options/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
},
"dependencies": {
"@agoric/babel-parser": "^7.6.4",
"@agoric/transform-eventual-send": "^1.0.4",
"@agoric/transform-eventual-send": "^1.1.0",
"@babel/generator": "^7.6.4"
},
"keywords": [],
Expand Down
4 changes: 2 additions & 2 deletions packages/eventual-send/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@
[![dev dependency status][dev-deps-svg]][dev-deps-url]
[![License][license-image]][license-url]

Extend the Promise class to implements the eventual-send API. This API is used by the ECMAScript eventual-send proposal.
Create a HandledPromise class to implement the eventual-send API. This API is used by the [ECMAScript eventual-send proposal](https://github.com/tc39/proposal-eventual-send).

## How to use

> Note: If you're writing an application, you probably don't want to use this package directly. You'll want to use the eventual-send `~.` operator (tildot) provided in [SES](https://github.com/Agoric/SES) or other platforms.
After importing `@agoric/eventual-send`, the updated `Promise` class can be used as described in `test/test.js`.
After importing `@agoric/eventual-send`, the exported `HandledPromise` class can be used as described in `test/test.js`.

[circleci-svg]: https://circleci.com/gh/Agoric/eventual-send.svg?style=svg
[circleci-url]: https://circleci.com/gh/Agoric/eventual-send
Expand Down
9 changes: 8 additions & 1 deletion packages/eventual-send/changelogs/6.txt
Original file line number Diff line number Diff line change
@@ -1 +1,8 @@
implement `new HandledPromise` interface
implement updated `HandledPromise` interface:
* use `new HandledPromise(...args)` instead of `Promise.makeHandled(...args)`
* use `HandledPromise.resolve(x)` (exported also as `E.resolve(x)`) which
returns x if it is already a HandledPromise or Promise, or x's corresponding
HandledPromise, or a new HandledPromise
* the promise handler now uses `get` instead of `GET` and `applyMethod` instead of `POST`
* delete, has, and set traps and their corresponding `E` operations have been removed as per the spec
* the `E.C` experimental "eventual chain" proxy has been removed
4 changes: 2 additions & 2 deletions packages/zoe/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
"homepage": "https://github.com/Agoric/agoric-sdk#readme",
"dependencies": {
"@agoric/ertp": "^0.2.0",
"@agoric/evaluate": "^2.1.3",
"@agoric/eventual-send": "^0.4.5",
"@agoric/evaluate": "^2.2.0",
"@agoric/eventual-send": "^0.5.0",
"@agoric/harden": "^0.0.4",
"@agoric/marshal": "^0.1.1",
"@agoric/nat": "^2.0.1",
Expand Down

0 comments on commit b9ed6b5

Please sign in to comment.