From a3fe3be04268bc16cfa6e15f5211498ecf19ac6b Mon Sep 17 00:00:00 2001 From: Brian Warner Date: Fri, 22 Mar 2024 17:21:04 -0700 Subject: [PATCH] fix(swingset): force flaky GC test to use XS only Sometimes, for reasons we don't entirely understand, Node.js doesn't garbage-collect objects when we tell it to, and we get flaky GC-checking tests. This applies our usual fix, which is to only run those tests under XS. It also stops attempting to use `test.serial` as a workaround. refs #3240 refs #5575 fixes #9089 --- packages/SwingSet/test/test-gc-kernel.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/SwingSet/test/test-gc-kernel.js b/packages/SwingSet/test/test-gc-kernel.js index 24ef843353e..2ceecabd9ed 100644 --- a/packages/SwingSet/test/test-gc-kernel.js +++ b/packages/SwingSet/test/test-gc-kernel.js @@ -1172,14 +1172,14 @@ test('terminated vat', async t => { }); // device receives object from vat a, returns to vat b - -test.serial('device transfer', async t => { +test('device transfer', async t => { function vatpath(fn) { return { sourceSpec: new URL(`gc-device-transfer/${fn}`, import.meta.url).pathname, }; } const config = { + defaultManagerType: 'xs-worker', // Avoid local vat nondeterminism vats: { bootstrap: vatpath('bootstrap-gc.js'), left: vatpath('vat-left-gc.js'),