fix(swingset): implement replayTranscript for all vat types

"local" workers had this already, but "nodeWorker" and "subprocess-node" did not.
Agoric · Jan 18, 2021 · 7fde6a4 · 7fde6a4
1 parent ca4188b
commit 7fde6a4
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 8 deletions.
diff --git a/packages/SwingSet/src/kernel/vatManager/nodeWorker.js b/packages/SwingSet/src/kernel/vatManager/nodeWorker.js
@@ -33,7 +33,9 @@ export function makeNodeWorkerVatManagerFactory(tools) {
       // TODO: warn+ignore, rather than throw, because the kernel enables it
       // for all vats, because the Spawner still needs it. When the kernel
       // stops doing that, turn this into a regular assert
-      console.log(`node-worker does not support enableInternalMetering`);
+      console.log(
+        `node-worker does not support enableInternalMetering, ignoring`,
+      );
     }
     const vatKeeper = kernelKeeper.getVatKeeper(vatID);
     const transcriptManager = makeTranscriptManager(
@@ -135,9 +137,16 @@ export function makeNodeWorkerVatManagerFactory(tools) {
       return pr.promise;
     }
 
-    function replayTranscript() {
-      // TODO unimplemented
-      throw Error(`replayTranscript not yet implemented`);
+    async function replayTranscript() {
+      transcriptManager.startReplay();
+      for (const t of vatKeeper.getTranscript()) {
+        transcriptManager.checkReplayError();
+        transcriptManager.startReplayDelivery(t.syscalls);
+        // eslint-disable-next-line no-await-in-loop
+        await deliver(t.d);
+      }
+      transcriptManager.checkReplayError();
+      transcriptManager.finishReplay();
     }
 
     function shutdown() {

diff --git a/packages/SwingSet/src/kernel/vatManager/worker-subprocess-node.js b/packages/SwingSet/src/kernel/vatManager/worker-subprocess-node.js
@@ -34,7 +34,9 @@ export function makeNodeSubprocessFactory(tools) {
       // TODO: warn+ignore, rather than throw, because the kernel enables it
       // for all vats, because the Spawner still needs it. When the kernel
       // stops doing that, turn this into a regular assert
-      console.log(`node-worker does not support enableInternalMetering`);
+      console.log(
+        `node-worker does not support enableInternalMetering, ignoring`,
+      );
     }
     const vatKeeper = kernelKeeper.getVatKeeper(vatID);
     const transcriptManager = makeTranscriptManager(
@@ -135,9 +137,16 @@ export function makeNodeSubprocessFactory(tools) {
       return pr.promise;
     }
 
-    function replayTranscript() {
-      // TODO unimplemented
-      throw Error(`replayTranscript not yet implemented`);
+    async function replayTranscript() {
+      transcriptManager.startReplay();
+      for (const t of vatKeeper.getTranscript()) {
+        transcriptManager.checkReplayError();
+        transcriptManager.startReplayDelivery(t.syscalls);
+        // eslint-disable-next-line no-await-in-loop
+        await deliver(t.d);
+      }
+      transcriptManager.checkReplayError();
+      transcriptManager.finishReplay();
     }
 
     function shutdown() {