fix: require virtual object selves to be declared Far

Fixes bug #3562
Agoric · Jul 30, 2021 · 6bb337b · 6bb337b
1 parent 9506ddb
commit 6bb337b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/packages/SwingSet/src/kernel/virtualObjectManager.js b/packages/SwingSet/src/kernel/virtualObjectManager.js
@@ -2,6 +2,7 @@
 
 import { assert, details as X, quote as q } from '@agoric/assert';
 import { Nat } from '@agoric/nat';
+import { getInterfaceOf } from '@agoric/marshal';
 import { parseVatSlot } from '../parseVatSlots.js';
 // import { kdebug } from './kdebug.js';
 
@@ -755,6 +756,10 @@ export function makeVirtualObjectManager(
         init(...args);
       }
       innerSelf.representative = initialRepresentative;
+      assert(
+        getInterfaceOf(initialRepresentative),
+        `self must be declared Far`,
+      );
       registerEntry(vobjID, initialRepresentative);
       initializationsInProgress.delete(initialData);
       const rawData = {};

diff --git a/packages/SwingSet/test/virtualObjects/vat-vom-gc-bob.js b/packages/SwingSet/test/virtualObjects/vat-vom-gc-bob.js
@@ -10,11 +10,11 @@ export function buildRootObject(_vatPowers) {
       init(label) {
         state.label = label;
       },
-      self: {
+      self: Far('thing', {
         getLabel() {
           return state.label;
         },
-      },
+      }),
     };
   }