From 62411f535c8eca6ea3689e32463fa5b6cf09c0bc Mon Sep 17 00:00:00 2001
From: Brian Warner <warner@lothar.com>
Date: Thu, 20 May 2021 11:39:11 -0700
Subject: [PATCH] fix!: drop Node.js v12 support, require v14.15.0 or higher

BREAKING CHANGE: The agoric-sdk as a whole now requires/advises v14.

We're leaving the individual package.jsons alone until a specific updated
requirement is found for each (e.g. SwingSet will soon bump to v14 because it
will require WeakRef). We won't be testing v12 support anywhere, but it's
possible that individual packages will still work with v12 until we believe
otherwise.

closes #1925
closes #837

Co-authored-by: Mathieu Hofman <86499+mhofman@users.noreply.github.com>
---
 .github/workflows/ag-solo-xs.yml.DISABLED |  2 +-
 .github/workflows/integration.yml         |  2 +-
 .github/workflows/test-all-packages.yml   | 27 ++++++++++++++++-------
 README.md                                 |  3 ++-
 package.json                              |  2 +-
 5 files changed, 24 insertions(+), 12 deletions(-)

diff --git a/.github/workflows/ag-solo-xs.yml.DISABLED b/.github/workflows/ag-solo-xs.yml.DISABLED
index b11d5810f9b..babff3a9448 100644
--- a/.github/workflows/ag-solo-xs.yml.DISABLED
+++ b/.github/workflows/ag-solo-xs.yml.DISABLED
@@ -18,7 +18,7 @@ jobs:
     - uses: actions/checkout@v2
     - uses: actions/setup-node@v1
       with:
-        node-version: '12.x'
+        node-version: '14.x'
     - name: cache node modules
       uses: actions/cache@v1
       with:
diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml
index 3c3e9afb149..5bf354bd61f 100644
--- a/.github/workflows/integration.yml
+++ b/.github/workflows/integration.yml
@@ -17,7 +17,7 @@ jobs:
 
     - uses: actions/setup-node@v1
       with:
-        node-version: '12.x'
+        node-version: '14.x'
     - name: cache node modules
       uses: actions/cache@v1
       with:
diff --git a/.github/workflows/test-all-packages.yml b/.github/workflows/test-all-packages.yml
index 5148036bca3..aeda1575100 100644
--- a/.github/workflows/test-all-packages.yml
+++ b/.github/workflows/test-all-packages.yml
@@ -14,7 +14,8 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: ['12.x', '14.x']
+        # TODO: ['14.x', '16.x']
+        node-version: ['14.x']
     steps:
     - uses: actions/checkout@v2
       with:
@@ -51,7 +52,8 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: ['12.x']
+        # note: only use one node-version
+        node-version: ['14.x']
     steps:
     - uses: actions/setup-node@v1
       with:
@@ -83,6 +85,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
+        # note: only use one node-version
         node-version: ['14.x']
     if: ${{github.event_name == 'push' && github.ref == 'refs/heads/master'}}
     steps:
@@ -122,6 +125,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
+        # note: only use one node-version
         node-version: ['14.x']
     if: ${{github.event_name == 'push' && github.ref == 'refs/heads/master'}}
     steps:
@@ -177,7 +181,8 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: ['12.x', '14.x']
+        # TODO: ['14.x', '16.x']
+        node-version: ['14.x']
     steps:
     - uses: actions/setup-node@v1
       with:
@@ -306,7 +311,8 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: ['12.x', '14.x']
+        # TODO: ['14.x', '16.x']
+        node-version: ['14.x']
     steps:
     - uses: actions/setup-node@v1
       with:
@@ -372,7 +378,8 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: ['12.x', '14.x']
+        # TODO: ['14.x', '16.x']
+        node-version: ['14.x']
     steps:
     - uses: actions/setup-node@v1
       with:
@@ -410,7 +417,8 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: ['12.x', '14.x']
+        # TODO: ['14.x', '16.x']
+        node-version: ['14.x']
     steps:
     - uses: actions/setup-node@v1
       with:
@@ -457,7 +465,8 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: ['12.x', '14.x']
+        # TODO: ['14.x', '16.x']
+        node-version: ['14.x']
     steps:
     - uses: actions/setup-node@v1
       with:
@@ -502,7 +511,8 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: ['12.x', '14.x']
+        # TODO: ['14.x', '16.x']
+        node-version: ['14.x']
     steps:
     - uses: actions/setup-node@v1
       with:
@@ -540,6 +550,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
+        # note: only use one node-version, maybe
         node-version: ['14.x']
     steps:
     - uses: actions/setup-node@v1
diff --git a/README.md b/README.md
index cf7f8806dc7..6c8cbc73ccb 100644
--- a/README.md
+++ b/README.md
@@ -17,7 +17,8 @@ to use.
 ## Prerequisites
 
 * Git
-* Node.js (version 12.14.1 or higher)
+* Node.js LTS (version 14.15.0 or higher)
+  * we generally support the latest LTS release: use [nvm](https://github.com/nvm-sh/nvm) to keep your local system up-to-date
 * Yarn (`npm install -g yarn`)
 
 Any version of Yarn will do: the `.yarnrc` file should ensure that all
diff --git a/package.json b/package.json
index 39b64ac2d60..5eb587dbb47 100644
--- a/package.json
+++ b/package.json
@@ -63,7 +63,7 @@
     "typescript": "^4.2.3"
   },
   "engines": {
-    "node": ">=12.14.1"
+    "node": ">=14.15.0"
   },
   "scripts": {
     "OFF-clean": "yarn workspaces run clean",