Updated config format #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
jianding17
reviewed
Dec 31, 2021
jianding17
reviewed
Dec 31, 2021
jianding17
reviewed
Jan 3, 2022
| @@ -22,6 +22,83 @@ void PacketTXRX::LoopTxRxArgos(size_t tid) { | |||
| std::min((radio_lo + radios_per_thread), cfg_->NumRadios()) - 1; | |||
|
|
|||
| threads_started_.fetch_add(1); | |||
|
|
|||
| long long time0 = 0; | |||
| if (cfg_->HwFramer() == false) { | |||
There was a problem hiding this comment.
Since this is a big chunk of code, we should add some comments about what this chunk of code does (maybe we should also explain what HwFramer()==false means here since it is not very intuitive).
There was a problem hiding this comment.
Added some comments here. See if it makes sense.
|
Update readability per guidelines. Retested ul / dl on powder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.