-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated config format #338
Conversation
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
@@ -22,6 +22,83 @@ void PacketTXRX::LoopTxRxArgos(size_t tid) { | |||
std::min((radio_lo + radios_per_thread), cfg_->NumRadios()) - 1; | |||
|
|||
threads_started_.fetch_add(1); | |||
|
|||
long long time0 = 0; | |||
if (cfg_->HwFramer() == false) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a big chunk of code, we should add some comments about what this chunk of code does (maybe we should also explain what HwFramer()==false means here since it is not very intuitive).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments here. See if it makes sense.
Update readability per guidelines. Retested ul / dl on powder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Addressed issue #336 to avoid crashing but it should be fixed in a more rigorous way in the next update
No description provided.