Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Coverage #216

Open
roblevintennis opened this issue May 3, 2022 · 0 comments
Open

Test Coverage #216

roblevintennis opened this issue May 3, 2022 · 0 comments
Labels
help wanted Extra attention is needed v2 Stuff we'll get to after v1 release
Milestone

Comments

@roblevintennis
Copy link
Contributor

roblevintennis commented May 3, 2022

Epic — Test Coverage

We will likely break this up into framework specific issues like "Vue Test Coverage", "React Test Coverage", etc. For now, I just wanted to capture the overall notion that we'd like to increase test coverage…


There's a whole back story on why, but we don't have great test coverage across AgnosticUI. At one point we were starting to in some of the packages, but, then we did big upgrades from Svelte to SvelteKit, Vue 2 to Vue 3, etc., etc.

I do find that certain tests can do more harm than good e.g. when a unit test delves deep into the implementation details of the system under test, or, really complex setups or spies. This can cause a huge burden in making bug fixes, refactoring, etc., if it's extremely hard to understand the setup.

I've had success using Cypress to do "just enough" testing. This is an example of a very simple Cypress script I used when doing the port of vue-a11y-dialog to Vue 3:
https://github.com/morkro/vue-a11y-dialog/blob/main/src/Demo.spec.ct.js

As can be seen, the tests are quite simple yet supply a pretty decent amount of coverage. I would like us to take a similar approach and start to add test coverage across the Svelte, Vue 3, and React implementations.

@roblevintennis roblevintennis added good first issue Good for newcomers help wanted Extra attention is needed v2 Stuff we'll get to after v1 release labels May 3, 2022
@roblevintennis roblevintennis added this to the v2 milestone May 18, 2022
@roblevintennis roblevintennis removed the good first issue Good for newcomers label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed v2 Stuff we'll get to after v1 release
Projects
None yet
Development

No branches or pull requests

1 participant