Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning #1

Open
moohkooh opened this issue Oct 10, 2017 · 2 comments
Open

Versioning #1

moohkooh opened this issue Oct 10, 2017 · 2 comments

Comments

@moohkooh
Copy link

Hi,
maybe its better to create versioning for your package. Im running in version conflict, because your moment dependency is not set to a version.

@dominique-mueller
Copy link

dominique-mueller commented Mar 26, 2018

When looking at the implementation, it seems that this package should work with all moment.js version. In our case, it does just fine.

What's the exact issue you get?

@antigen42
Copy link

Hi, i think you should use moment.js like peerDependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants