Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation does not mention allowing com.ryanharter.auto.value.gson.GsonTypeAdapterFactory with Proguard, but cannot minify app with this library included. #139

Open
sonrohan opened this issue Oct 30, 2024 · 0 comments

Comments

@sonrohan
Copy link

sonrohan commented Oct 30, 2024

I included the affirm SDK in my Android code. When I build debug everything is fine. But when I build in release mode, the compiler warns that

Missing classes detected while running R8. Please add the missing classes or apply additional keep rules that are generated in /Users/<user>/repos/<project>/app/build/outputs/mapping/debug/missing_rules.txt.

I didn't see this mentioned anywhere in the documentation. Should I mark this as keep or do not warn? Also can this be fixed on the SDK side? I am worried this will crash at run time.

Steps to reproduce:

  • Start a new project
  • Create 2 build variants if they do not already exist. debug and release
  • Use these settings for debug
isMinifyEnabled = true
proguardFiles(getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro")
testProguardFile("proguard-test.pro")
  • Compile your app in debug mode

You will see

Missing classes detected while running R8. Please add the missing classes or apply additional keep rules that are generated in /Users/<user>/repos/<project>/app/build/outputs/mapping/debug/missing_rules.txt.

@sonrohan sonrohan changed the title Documentation does mention allowing com.ryanharter.auto.value.gson.GsonTypeAdapterFactory with Proguard, but cannot minify app with this library included. Documentation does not mention allowing com.ryanharter.auto.value.gson.GsonTypeAdapterFactory with Proguard, but cannot minify app with this library included. Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant