-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ApplePay Express #133
Merged
Merged
ApplePay Express #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: ovveride cart page * feat: override cart cta partial * feat: render apple pay button * chore: make apple button full width * chore: revert style changes
* feat: ovveride cart page * feat: override cart cta partial * feat: render apple pay button * chore: make apple button full width * chore: revert style changes * feat: handle onauthorised callback when doing apple payment * chore: check customer id
* feat: handle on shipping method change * chore: use post instead of put * chore: removed unused import
* feat: handle on shipping method change * chore: use post instead of put * chore: removed unused import * chore: reorder files and export properly * feat: use components from built folder * fix: test imports
* feat: provide shipping detail to the payments call * chore: removed onError callback * feat: unit tests for shipping methods * feat: new endpoint for fetching shipping methods * fix: tests * chore: not pass the shipping methods * feat: fetch shipping methods once contact is changed * fix: unit test * feat: unit tests for shipping methods and address * chore: maintain shipping unit tests * feat: apple pay express tests * chore: unit tests for context * feat: unit tests for express context * feat: handle error scenario in unit tests
amihajlovski
requested review from
shanikantsingh,
zenit2001 and
ShubhamVijaivargiya
as code owners
April 8, 2024 07:51
Quality Gate passedIssues Measures |
shanikantsingh
approved these changes
Apr 12, 2024
zenit2001
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Describe the changes proposed in this pull request:
Tested scenarios
Description of tested scenarios:
Fixed issue: SFI-437