Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/component exports #131

Merged
merged 7 commits into from
Mar 29, 2024

Conversation

amihajlovski
Copy link
Collaborator

Summary

Describe the changes proposed in this pull request:

  • What is the motivation for this change?
  • Export the contexts properly
  • What existing problem does this pull request solve?
  • Use the exports in the retail app

Copy link

sonarcloud bot commented Mar 29, 2024

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@amihajlovski amihajlovski merged commit 6a71e5d into feature/apple-pay-express Mar 29, 2024
4 checks passed
@amihajlovski amihajlovski deleted the improvement/component-exports branch March 29, 2024 14:01
amihajlovski added a commit that referenced this pull request Apr 12, 2024
* chore: move pages to the retail app package

* chore: remove console log

* chore: remove imports

* feat: fresh node-modules

* feat: fresh node modules

* Render ApplePay express button (#127)

* feat: ovveride cart page

* feat: override cart cta partial

* feat: render apple pay button

* chore: make apple button full width

* chore: revert style changes

* Handle onAuthorised (#129)

* feat: ovveride cart page

* feat: override cart cta partial

* feat: render apple pay button

* chore: make apple button full width

* chore: revert style changes

* feat: handle onauthorised callback when doing apple payment

* chore: check customer id

* handle on shipping method change (#130)

* feat: handle on shipping method change

* chore: use post instead of put

* chore: removed unused import

* Improvement/component exports (#131)

* feat: handle on shipping method change

* chore: use post instead of put

* chore: removed unused import

* chore: reorder files and export properly

* feat: use components from built folder

* fix: test imports

* Shipping details (#132)

* feat: provide shipping detail to the payments call

* chore: removed onError callback

* feat: unit tests for shipping methods

* feat: new endpoint for fetching shipping methods

* fix: tests

* chore: not pass the shipping methods

* feat: fetch shipping methods once contact is changed

* fix: unit test

* feat: unit tests for shipping methods and address

* chore: maintain shipping unit tests

* feat: apple pay express tests

* chore: unit tests for context

* feat: unit tests for express context

* feat: handle error scenario in unit tests

* feat: upgrade pwa kit

* feat: upgrade pwa kit

* chore: revert

* fix: fetching shipping methods

* fix: packages

* feat: include telemetery

* fix: unit tests

* feat: increment retail app

* chore: change e2e product selectors
@amihajlovski amihajlovski added the excluded Will be ignored in the release notes label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
excluded Will be ignored in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant