Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installments add rule button not rendering properly #1023

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

zenit2001
Copy link
Contributor

@zenit2001 zenit2001 commented Dec 4, 2023

Summary

  • What is the motivation for this change?
    The Add Rule button for installments overwrites the text when there are no installment options setup.
  • What existing problem does this pull request solve?
    It positions the Add Rule button in a static place, where it will not overwrite the text.
    It also adds a validation in case installments are not enabled, to not render them in the component.
    Fixed issue:

@zenit2001 zenit2001 changed the title Bugfix/installments add rule button Installments add rule button not rendering properly Dec 4, 2023
@zenit2001 zenit2001 marked this pull request as ready for review December 4, 2023 16:27
@zenit2001 zenit2001 added the fix Fixes a bug label Dec 4, 2023
Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zenit2001 zenit2001 merged commit 0494251 into develop Dec 5, 2023
15 checks passed
@zenit2001 zenit2001 deleted the bugfix/installments-add-rule-button branch December 5, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants