[PW-7481] - Fix configuration value override for array values #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candemiralp
changed the title
peterojo
previously approved these changes
Nov 14, 2022
RokPopov
approved these changes
Nov 14, 2022
peterojo
approved these changes
Nov 14, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
convertKeysToCamel()function is converting configuration array keys and values to camel case and cleans up the dashes and underscores.However, configuration array values carry case sensitive information like merchant account.
Expected output is
gatewatMerchantId: Some_MerchantAccount_NameActual value is
gatewatMerchantId: SomeMerchantAccountNameThis causes wrong gatewayMerchantId to be sent to Google. Now, only the array keys are being converted to camel case.
Tested scenarios