Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PW-7592] Allow merchants to de-select all options in express checkout config #17

Merged
merged 1 commit into from
Dec 5, 2022
Merged

[PW-7592] Allow merchants to de-select all options in express checkout config #17

merged 1 commit into from
Dec 5, 2022

Conversation

peterojo
Copy link
Contributor

@peterojo peterojo commented Dec 5, 2022

Summary

Allow sending empty value in show_xxxpay_on fields, so that merchants are able to deselect all the options

Tested scenarios

  • De-select 'PDP, cart, and mini-cart' in config, DB value should be set to null

Fixed issue:

@peterojo peterojo requested a review from a team as a code owner December 5, 2022 14:54
@peterojo peterojo merged commit 1e5ae01 into develop Dec 5, 2022
@peterojo peterojo deleted the PW-7592 branch December 5, 2022 15:02
@peterojo peterojo mentioned this pull request Dec 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@candemiralp candemiralp candemiralp approved these changes

@Morerice Morerice Morerice approved these changes

@michaelpaul michaelpaul Awaiting requested review from michaelpaul michaelpaul was automatically assigned from

@acampos1916 acampos1916 Awaiting requested review from acampos1916 acampos1916 was automatically assigned from

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterojo @Morerice @candemiralp