Support partial payments #310

Robert-SD · 2024-11-19T14:12:15Z

No description provided.

github-actions · 2024-11-19T14:14:42Z

LCOV of commit `5d3dafd` during Check PR #937

Summary coverage rate:
  lines......: 10.1% (136 of 1353 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/common/adyen_checkout_session.dart                                                    | 0.0%     25|    -     0|    -      0
  lib/src/common/model/checkout.dart                                                            | 0.0%      2|    -     0|    -      0
  lib/src/common/model/partial_payment/order_cancel_response.dart                               | 0.0%      1|    -     0|    -      0
  lib/src/common/model/partial_payment/partial_payment.dart                                     | 0.0%      1|    -     0|    -      0
  lib/src/common/model/payment_event.dart                                                       | 0.0%      4|    -     0|    -      0
  lib/src/drop_in/drop_in.dart                                                                  | 0.0%    163|    -     0|    -      0
  lib/src/drop_in/drop_in_platform_api.dart                                                     | 0.0%     18|    -     0|    -      0
  lib/src/util/dto_mapper.dart                                                                  |63.8%    185|    -     0|    -      0
  lib/src/util/payment_event_handler.dart                                                       | 0.0%     14|    -     0|    -      0

github-actions · 2024-11-19T15:42:35Z

LCOV of commit `9dbcbb5` during Check PR #938

Summary coverage rate:
  lines......: 10.1% (136 of 1353 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/common/adyen_checkout_session.dart                                                    | 0.0%     25|    -     0|    -      0
  lib/src/common/model/checkout.dart                                                            | 0.0%      2|    -     0|    -      0
  lib/src/common/model/partial_payment/order_cancel_response.dart                               | 0.0%      1|    -     0|    -      0
  lib/src/common/model/partial_payment/partial_payment.dart                                     | 0.0%      1|    -     0|    -      0
  lib/src/common/model/payment_event.dart                                                       | 0.0%      4|    -     0|    -      0
  lib/src/drop_in/drop_in.dart                                                                  | 0.0%    163|    -     0|    -      0
  lib/src/drop_in/drop_in_platform_api.dart                                                     | 0.0%     18|    -     0|    -      0
  lib/src/util/dto_mapper.dart                                                                  |63.8%    185|    -     0|    -      0
  lib/src/util/payment_event_handler.dart                                                       | 0.0%     14|    -     0|    -      0

github-actions · 2024-11-19T16:16:40Z

LCOV of commit `ba5938d` during Check PR #939

Summary coverage rate:
  lines......: 10.1% (136 of 1353 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/common/adyen_checkout_session.dart                                                    | 0.0%     25|    -     0|    -      0
  lib/src/common/model/checkout.dart                                                            | 0.0%      2|    -     0|    -      0
  lib/src/common/model/partial_payment/order_cancel_response.dart                               | 0.0%      1|    -     0|    -      0
  lib/src/common/model/partial_payment/partial_payment.dart                                     | 0.0%      1|    -     0|    -      0
  lib/src/common/model/payment_event.dart                                                       | 0.0%      4|    -     0|    -      0
  lib/src/drop_in/drop_in.dart                                                                  | 0.0%    163|    -     0|    -      0
  lib/src/drop_in/drop_in_platform_api.dart                                                     | 0.0%     18|    -     0|    -      0
  lib/src/util/dto_mapper.dart                                                                  |63.8%    185|    -     0|    -      0
  lib/src/util/payment_event_handler.dart                                                       | 0.0%     14|    -     0|    -      0

Robert-SD · 2024-11-21T09:44:20Z

android/src/main/kotlin/com/adyen/checkout/flutter/PlatformApi.kt

Generated code - no review required.

github-actions · 2024-11-21T09:56:53Z

LCOV of commit `e068042` during Check PR #940

Summary coverage rate:
  lines......: 10.1% (136 of 1353 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/common/adyen_checkout_session.dart                                                    | 0.0%     25|    -     0|    -      0
  lib/src/common/model/checkout.dart                                                            | 0.0%      2|    -     0|    -      0
  lib/src/common/model/partial_payment/order_cancel_response.dart                               | 0.0%      1|    -     0|    -      0
  lib/src/common/model/partial_payment/partial_payment.dart                                     | 0.0%      1|    -     0|    -      0
  lib/src/common/model/payment_event.dart                                                       | 0.0%      4|    -     0|    -      0
  lib/src/drop_in/drop_in.dart                                                                  | 0.0%    163|    -     0|    -      0
  lib/src/drop_in/drop_in_platform_api.dart                                                     | 0.0%     18|    -     0|    -      0
  lib/src/util/dto_mapper.dart                                                                  |63.8%    185|    -     0|    -      0
  lib/src/util/payment_event_handler.dart                                                       | 0.0%     14|    -     0|    -      0

Robert-SD · 2024-11-21T10:10:29Z

lib/src/generated/platform_api.g.dart

Generated code - no review required.

github-actions · 2024-11-21T10:56:51Z

LCOV of commit `6e6b94f` during Check PR #941

Summary coverage rate:
  lines......: 10.1% (136 of 1353 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/common/adyen_checkout_session.dart                                                    | 0.0%     25|    -     0|    -      0
  lib/src/common/model/checkout.dart                                                            | 0.0%      2|    -     0|    -      0
  lib/src/common/model/partial_payment/order_cancel_response.dart                               | 0.0%      1|    -     0|    -      0
  lib/src/common/model/partial_payment/partial_payment.dart                                     | 0.0%      1|    -     0|    -      0
  lib/src/common/model/payment_event.dart                                                       | 0.0%      4|    -     0|    -      0
  lib/src/drop_in/drop_in.dart                                                                  | 0.0%    163|    -     0|    -      0
  lib/src/drop_in/drop_in_platform_api.dart                                                     | 0.0%     18|    -     0|    -      0
  lib/src/util/dto_mapper.dart                                                                  |63.8%    185|    -     0|    -      0
  lib/src/util/payment_event_handler.dart                                                       | 0.0%     14|    -     0|    -      0

github-actions · 2024-11-21T12:24:39Z

LCOV of commit `4754226` during Check PR #942

Summary coverage rate:
  lines......: 10.1% (136 of 1352 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/common/adyen_checkout_session.dart                                                    | 0.0%     25|    -     0|    -      0
  lib/src/common/model/checkout.dart                                                            | 0.0%      2|    -     0|    -      0
  lib/src/common/model/partial_payment/order_cancel_result.dart                                 | 0.0%      1|    -     0|    -      0
  lib/src/common/model/partial_payment/partial_payment.dart                                     | 0.0%      1|    -     0|    -      0
  lib/src/common/model/payment_event.dart                                                       | 0.0%      4|    -     0|    -      0
  lib/src/drop_in/drop_in.dart                                                                  | 0.0%    163|    -     0|    -      0
  lib/src/drop_in/drop_in_platform_api.dart                                                     | 0.0%     18|    -     0|    -      0
  lib/src/util/dto_mapper.dart                                                                  |64.1%    184|    -     0|    -      0
  lib/src/util/payment_event_handler.dart                                                       | 0.0%     14|    -     0|    -      0

github-actions · 2024-11-21T12:38:39Z

LCOV of commit `0db23b6` during Check PR #943

Summary coverage rate:
  lines......: 10.1% (136 of 1349 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/common/adyen_checkout_session.dart                                                    | 0.0%     25|    -     0|    -      0
  lib/src/common/model/checkout.dart                                                            | 0.0%      2|    -     0|    -      0
  lib/src/common/model/partial_payment/order_cancel_result.dart                                 | 0.0%      1|    -     0|    -      0
  lib/src/common/model/partial_payment/partial_payment.dart                                     | 0.0%      1|    -     0|    -      0
  lib/src/common/model/payment_event.dart                                                       | 0.0%      4|    -     0|    -      0
  lib/src/drop_in/drop_in.dart                                                                  | 0.0%    160|    -     0|    -      0
  lib/src/drop_in/drop_in_platform_api.dart                                                     | 0.0%     18|    -     0|    -      0
  lib/src/util/dto_mapper.dart                                                                  |64.1%    184|    -     0|    -      0
  lib/src/util/payment_event_handler.dart                                                       | 0.0%     14|    -     0|    -      0

Robert-SD · 2024-11-21T12:44:10Z

ios/Classes/PlatformApi.swift

Generated code - no review required.

github-actions · 2024-11-21T13:02:34Z

LCOV of commit `3858cae` during Check PR #944

Summary coverage rate:
  lines......: 10.1% (136 of 1349 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/common/adyen_checkout_session.dart                                                    | 0.0%     25|    -     0|    -      0
  lib/src/common/model/checkout.dart                                                            | 0.0%      2|    -     0|    -      0
  lib/src/common/model/partial_payment/order_cancel_result.dart                                 | 0.0%      1|    -     0|    -      0
  lib/src/common/model/partial_payment/partial_payment.dart                                     | 0.0%      1|    -     0|    -      0
  lib/src/common/model/payment_event.dart                                                       | 0.0%      4|    -     0|    -      0
  lib/src/drop_in/drop_in.dart                                                                  | 0.0%    160|    -     0|    -      0
  lib/src/drop_in/drop_in_platform_api.dart                                                     | 0.0%     18|    -     0|    -      0
  lib/src/util/dto_mapper.dart                                                                  |64.1%    184|    -     0|    -      0
  lib/src/util/payment_event_handler.dart                                                       | 0.0%     14|    -     0|    -      0

github-actions · 2024-11-21T15:03:19Z

LCOV of commit `d79c350` during Check PR #945

Summary coverage rate:
  lines......: 10.1% (136 of 1349 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/common/adyen_checkout_session.dart                                                    | 0.0%     25|    -     0|    -      0
  lib/src/common/model/checkout.dart                                                            | 0.0%      2|    -     0|    -      0
  lib/src/common/model/partial_payment/order_cancel_result.dart                                 | 0.0%      1|    -     0|    -      0
  lib/src/common/model/partial_payment/partial_payment.dart                                     | 0.0%      1|    -     0|    -      0
  lib/src/common/model/payment_event.dart                                                       | 0.0%      4|    -     0|    -      0
  lib/src/drop_in/drop_in.dart                                                                  | 0.0%    160|    -     0|    -      0
  lib/src/drop_in/drop_in_platform_api.dart                                                     | 0.0%     18|    -     0|    -      0
  lib/src/util/dto_mapper.dart                                                                  |64.1%    184|    -     0|    -      0
  lib/src/util/payment_event_handler.dart                                                       | 0.0%     14|    -     0|    -      0

github-actions · 2024-11-28T12:24:58Z

LCOV of commit `1307490` during Check PR #956

Summary coverage rate:
  lines......: 10.1% (136 of 1344 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/common/adyen_checkout_session.dart                                                    | 0.0%     25|    -     0|    -      0
  lib/src/common/model/checkout.dart                                                            | 0.0%      2|    -     0|    -      0
  lib/src/common/model/partial_payment/order_cancel_result.dart                                 | 0.0%      1|    -     0|    -      0
  lib/src/common/model/partial_payment/partial_payment.dart                                     | 0.0%      1|    -     0|    -      0
  lib/src/common/model/payment_event.dart                                                       | 0.0%      4|    -     0|    -      0
  lib/src/drop_in/drop_in.dart                                                                  | 0.0%    160|    -     0|    -      0
  lib/src/drop_in/drop_in_platform_api.dart                                                     | 0.0%     18|    -     0|    -      0
  lib/src/util/dto_mapper.dart                                                                  |64.1%    184|    -     0|    -      0
  lib/src/util/payment_event_handler.dart                                                       | 0.0%     14|    -     0|    -      0

…I callbacks

… iOS

…eter names

github-actions · 2024-12-10T10:23:41Z

LCOV of commit `9cc78f6` during Check PR #965

Summary coverage rate:
  lines......: 10.1% (136 of 1344 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/common/adyen_checkout_session.dart                                                    | 0.0%     25|    -     0|    -      0
  lib/src/common/model/checkout.dart                                                            | 0.0%      2|    -     0|    -      0
  lib/src/common/model/partial_payment/order_cancel_result.dart                                 | 0.0%      1|    -     0|    -      0
  lib/src/common/model/partial_payment/partial_payment.dart                                     | 0.0%      1|    -     0|    -      0
  lib/src/common/model/payment_event.dart                                                       | 0.0%      4|    -     0|    -      0
  lib/src/drop_in/drop_in.dart                                                                  | 0.0%    160|    -     0|    -      0
  lib/src/drop_in/drop_in_platform_api.dart                                                     | 0.0%     18|    -     0|    -      0
  lib/src/util/dto_mapper.dart                                                                  |64.1%    184|    -     0|    -      0
  lib/src/util/payment_event_handler.dart                                                       | 0.0%     14|    -     0|    -      0

github-actions · 2024-12-10T13:26:30Z

LCOV of commit `c0c7a8d` during Check PR #970

Summary coverage rate:
  lines......: 10.1% (136 of 1344 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/common/adyen_checkout_session.dart                                                    | 0.0%     25|    -     0|    -      0
  lib/src/common/model/checkout.dart                                                            | 0.0%      2|    -     0|    -      0
  lib/src/common/model/partial_payment/order_cancel_result.dart                                 | 0.0%      1|    -     0|    -      0
  lib/src/common/model/partial_payment/partial_payment.dart                                     | 0.0%      1|    -     0|    -      0
  lib/src/common/model/payment_event.dart                                                       | 0.0%      4|    -     0|    -      0
  lib/src/drop_in/drop_in.dart                                                                  | 0.0%    160|    -     0|    -      0
  lib/src/drop_in/drop_in_platform_api.dart                                                     | 0.0%     18|    -     0|    -      0
  lib/src/util/dto_mapper.dart                                                                  |64.1%    184|    -     0|    -      0
  lib/src/util/payment_event_handler.dart                                                       | 0.0%     14|    -     0|    -      0

sonarcloud · 2024-12-10T13:39:58Z

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
11.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Robert-SD commented Nov 21, 2024

View reviewed changes

android/src/main/kotlin/com/adyen/checkout/flutter/PlatformApi.kt

Copy link

Collaborator Author

Robert-SD Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated code - no review required.

Robert-SD commented Nov 21, 2024

View reviewed changes

lib/src/generated/platform_api.g.dart

Copy link

Collaborator Author

Robert-SD Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated code - no review required.

Robert-SD commented Nov 21, 2024

View reviewed changes

ios/Classes/PlatformApi.swift

Copy link

Collaborator Author

Robert-SD Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated code - no review required.

Robert-SD marked this pull request as ready for review November 28, 2024 09:36

Robert-SD force-pushed the feature/addPartialPayments branch from d79c350 to 1307490 Compare November 28, 2024 12:23

Robert-SD added 14 commits December 10, 2024 11:21

Started with implementation of partial payment

d3935df

Added android partial payments flow

67fad31

Rebase with main

e18088f

Started with integration of partial payments for iOS

4714ba5

Completed partial payments for iOS and improved error handling for AP…

2981466

…I callbacks

removed error dialogs for android and fixed missing parameter name on…

7b68658

… iOS

Adjusted tests

ee8409c

Fixed failing android test

c84e42a

Improved naming

2e98c7b

Renamed OrderCancelResponse into OrderCancelResult and improved param…

4446cb0

…eter names

Added delay on Android layer until SDK update is available

86cc0f5

Changed constant names to camelCase

6b0b956

Improved naming of orderCancelResult class properties

c2d93eb

Added changelog entry

9cc78f6

Robert-SD force-pushed the feature/addPartialPayments branch from 1307490 to 9cc78f6 Compare December 10, 2024 10:22

Robert-SD added 3 commits December 10, 2024 14:25

Added badges and required minimum AGP version to readme

68ca648

Specified required AGP version

ac7a596

Adjusted required Kotlin version

c0c7a8d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support partial payments #310

Support partial payments #310

Robert-SD commented Nov 19, 2024

github-actions bot commented Nov 19, 2024

github-actions bot commented Nov 19, 2024

github-actions bot commented Nov 19, 2024

Robert-SD Nov 21, 2024

github-actions bot commented Nov 21, 2024

Robert-SD Nov 21, 2024

github-actions bot commented Nov 21, 2024

github-actions bot commented Nov 21, 2024

github-actions bot commented Nov 21, 2024

Robert-SD Nov 21, 2024

github-actions bot commented Nov 21, 2024

github-actions bot commented Nov 21, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Dec 10, 2024

github-actions bot commented Dec 10, 2024

sonarcloud bot commented Dec 10, 2024

Support partial payments #310

Are you sure you want to change the base?

Support partial payments #310

Conversation

Robert-SD commented Nov 19, 2024

github-actions bot commented Nov 19, 2024

LCOV of commit 5d3dafd during Check PR #937

github-actions bot commented Nov 19, 2024

LCOV of commit 9dbcbb5 during Check PR #938

github-actions bot commented Nov 19, 2024

LCOV of commit ba5938d during Check PR #939

Robert-SD Nov 21, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 21, 2024

LCOV of commit e068042 during Check PR #940

Robert-SD Nov 21, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 21, 2024

LCOV of commit 6e6b94f during Check PR #941

github-actions bot commented Nov 21, 2024

LCOV of commit 4754226 during Check PR #942

github-actions bot commented Nov 21, 2024

LCOV of commit 0db23b6 during Check PR #943

Robert-SD Nov 21, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 21, 2024

LCOV of commit 3858cae during Check PR #944

github-actions bot commented Nov 21, 2024

LCOV of commit d79c350 during Check PR #945

github-actions bot commented Nov 28, 2024

LCOV of commit 1307490 during Check PR #956

github-actions bot commented Dec 10, 2024

LCOV of commit 9cc78f6 during Check PR #965

github-actions bot commented Dec 10, 2024

LCOV of commit c0c7a8d during Check PR #970

sonarcloud bot commented Dec 10, 2024

Quality Gate failed

LCOV of commit `5d3dafd` during Check PR #937

LCOV of commit `9dbcbb5` during Check PR #938

LCOV of commit `ba5938d` during Check PR #939

LCOV of commit `e068042` during Check PR #940

LCOV of commit `6e6b94f` during Check PR #941

LCOV of commit `4754226` during Check PR #942

LCOV of commit `0db23b6` during Check PR #943

LCOV of commit `3858cae` during Check PR #944

LCOV of commit `d79c350` during Check PR #945

LCOV of commit `1307490` during Check PR #956

LCOV of commit `9cc78f6` during Check PR #965

LCOV of commit `c0c7a8d` during Check PR #970