Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case sensitive Issue on <clipPath> / <clippath> and InnerBlocks #514

Closed
CreativeDive opened this issue Jun 18, 2021 · 4 comments
Closed

Comments

@CreativeDive
Copy link
Collaborator

Hey @elliotcondon,

First of all, I would like to let you know that I am sad that you will no longer be part of ACF in the future.
It's hard to imagine that you will no longer be a contact for. Even if I understand your decision and think that it is the right decision for the plugin itself in the long run.

I wish you the best for your future.

I have over-noticed an issue using inner blocks. When I work with <clipPath> in the HTML markup, the HTML tag is written in lower case <clippath> in the editor. As a result, the ClipPath is not displayed correctly. Instead, it works very well in the frontend. Can this issue be related to how ACF changes code when inner blocks are part of a block?

@elliotcondon
Copy link
Contributor

Hi @CreativeDive,

That is so nice of you to say! Thanks for supporting my work, and my decision to ensure the project's success 🙌.

I can confirm this bug will be due to the "JSX Parser" which converts the server-side generated HTML into JSX within the browser. This parser loses case-sensitive HTML tags, which we will need to add back in manually. Luckily, most HTML tags are not case sensitive, but it appears that <clipPath> is. I'll add a note to develop some extra logic that allows this tag.

@CreativeDive
Copy link
Collaborator Author

@elliotcondon Thank you.

@CreativeDive
Copy link
Collaborator Author

@mattgrshaw thanks works like expected since ACF 5.9.8

@mattgrshaw
Copy link
Member

@CreativeDive Glad to hear!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants