Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACF blocks - Switch to edit mode fields inherit editor styles #492

Open
CreativeDive opened this issue May 7, 2021 · 1 comment
Open

Comments

@CreativeDive
Copy link
Collaborator

Hey @elliotcondon

If we use edit mode for ACF blocks within the block itself, the default ACF field styles break, because the fields inherit editor styles, if a theme use the WordPress function add_editor_styles().

Here is only one example, how it looks in my case:

Bildschirmfoto 2021-05-07 um 13 34 27

However, depending on the style contained in add_editor_styles(), the ACF fields can have a completely different appearance.

I know there is currently no way to fix this. But I was wondering if it is possible to open these block fields in a modal window instead. The modal window content should be located outside of the block editor ".editor-styles-wrapper" container. I think this is the only way to avoid having editor styles inherited from ACF block fields.

@elliotcondon
Copy link
Contributor

Thanks @CreativeDive. I'll add this to our to-do list and will consider a future proof solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants