Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0% Volume isn't zero volume #37

Closed
peturdainn opened this issue Oct 16, 2019 · 7 comments
Closed

0% Volume isn't zero volume #37

peturdainn opened this issue Oct 16, 2019 · 7 comments

Comments

@peturdainn
Copy link

When selecting 0% as volume I can still hear it in my headphones. Not loud but is there.
(as discovered with the green eSheep)

Maybe disable sound entirely if set to 0% ?

Thanks!

@Adrianotiger
Copy link
Owner

I will check it.
The sound should not be played, if the volume is set to 0%:
https://github.com/Adrianotiger/desktopPet/blob/master/src/dotNet/Animations.cs#L397

Could it be that the volume in the option was not saved?

@peturdainn
Copy link
Author

If I go back to options it is still set to 0%. Any place where I can check this? Is it stored somewhere accessible?

@Adrianotiger
Copy link
Owner

Settings are stored in a file called settings.json under:
...\AppData\Local\Packages\6469Adriano.esheep_ddd79p2qwj4yr\LocalState

@Adrianotiger
Copy link
Owner

I found the problem: if you change volume, it will be updated only on the next start. If you close the app, it works... Until you change the volume again.

Thank you for your feedback!

@peturdainn
Copy link
Author

Great find and thanks again for giving us this blast from the past (even if I can only use it at work, no Windows systems at home)

@Adrianotiger
Copy link
Owner

Should be solved with the last release.
Thank you again for reporting it and for your donation :)

@peturdainn
Copy link
Author

thanks for fixing & you're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants