Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animate fires redundant ThemeColorChanged events #266

Open
Inventsable opened this issue Jan 26, 2020 · 0 comments
Open

Animate fires redundant ThemeColorChanged events #266

Inventsable opened this issue Jan 26, 2020 · 0 comments

Comments

@Inventsable
Copy link

Inventsable commented Jan 26, 2020

Related to #265, since Animate doesn't allow you to differentiate between Dark/Darkest and Light/Lightest, I figured a good workaround would be to do this on every app theme change event:

  1. Compare appSkinInfo's inaccurate panelBackgroundColor's value to tell if a Dark/Light theme
  2. Compare the panel's current background color -- if appSkinInfo claims dark but the panel is already dark, it must have been a change to the close sibling (from Darkest to Dark, etc).

This works perfectly until you hit the OK button. In Animate alone, each of the following causes a ThemeColorChanged event:

  • Selecting a new theme from the menu dropdown (Correct)
  • Hitting Cancel to revert from selected menu dropdown's theme to the prior theme (Correct)
  • Hitting OK to confirm the new theme (Incorrect)

This behavior isn't present in any other app that I can tell, shouldn't be present since the appTheme has already been changed and this is simply a confirmation which adds no functionality not already handled by the menu/Cancel events, and unfortunately breaks what workaround I did find for the previous issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant