(chocolatey#770) Show additional message on no arguments

This commit updates the dialog for showing package arguments to have a notice that no arguments was found for the package in the same dialog as normal arguments would show up with.
AdmiringWorm · Jan 27, 2022 · 375fbce · 375fbce
1 parent 9d30975
commit 375fbce
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 4 deletions.
diff --git a/Source/ChocolateyGui.Common.Windows/Services/PackageArgumentsService.cs b/Source/ChocolateyGui.Common.Windows/Services/PackageArgumentsService.cs
@@ -61,7 +61,7 @@ public IEnumerable<string> DecryptPackageArgumentsFile(string id, string version
 
             if (string.IsNullOrEmpty(arguments))
             {
-                _dialogService.ShowMessageAsync(
+                Logger.Debug(
                     string.Empty,
                     L(nameof(Resources.PackageView_UnableToFindArgumentsFile), version, id));
                 yield break;

diff --git a/Source/ChocolateyGui.Common.Windows/ViewModels/Items/PackageViewModel.cs b/Source/ChocolateyGui.Common.Windows/ViewModels/Items/PackageViewModel.cs
@@ -431,9 +431,18 @@ public async Task ShowArguments()
         {
             var decryptedArguments = _packageArgumentsService.DecryptPackageArgumentsFile(Id, Version.ToString()).ToList();
 
-            await _dialogService.ShowMessageAsync(
-                L(nameof(Resources.PackageViewModel_ArgumentsForPackageFormat), Title),
-                string.Join(Environment.NewLine, decryptedArguments));
+            if (decryptedArguments.Count == 0)
+            {
+                await _dialogService.ShowMessageAsync(
+                    L(nameof(Resources.PackageViewModel_ArgumentsForPackageFormat), Title),
+                    L(nameof(Resources.PackageViewModel_NoArgumentsAvailableForPackage)));
+            }
+            else
+            {
+                await _dialogService.ShowMessageAsync(
+                    L(nameof(Resources.PackageViewModel_ArgumentsForPackageFormat), Title),
+                    string.Join(Environment.NewLine, decryptedArguments));
+            }
         }
 
         public async Task Install()

diff --git a/Source/ChocolateyGui.Common/Properties/Resources.Designer.cs b/Source/ChocolateyGui.Common/Properties/Resources.Designer.cs
diff --git a/Source/ChocolateyGui.Common/Properties/Resources.resx b/Source/ChocolateyGui.Common/Properties/Resources.resx
@@ -1349,4 +1349,7 @@ Please contact your System Administrator to enable this operation.</value>
   <data name="PackageArgumentService_RedactedArgument" xml:space="preserve">
     <value>[REDACTED ARGUMENT]</value>
   </data>
+  <data name="PackageViewModel_NoArgumentsAvailableForPackage" xml:space="preserve">
+    <value>There are no Persisted Arguments available for this package!</value>
+  </data>
 </root>