Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$popup disables simple blocking rule #2728

Closed
105th opened this issue Feb 29, 2024 · 0 comments
Closed

$popup disables simple blocking rule #2728

105th opened this issue Feb 29, 2024 · 0 comments

Comments

@105th
Copy link
Member

105th commented Feb 29, 2024

AdGuard Extension version

4.3.26 beta

Browser version

Chrome 122

OS version

macOS 12.5

What filters do you have enabled?

No response

What Stealth Mode options do you have enabled?

No response

Issue Details

Steps to reproduce:

  1. Add rules to the user-rules section (these rules were removed from our filters):
/gtm.js?$popup
||data.r.pl^
  1. Open the site r.pl.

Actual behavior:

The request to https://data.r.pl/gtm.js?id=GTM-5S6834 is not rejected because the tsurlfilter filtering engine selects the rule /gtm.js?$popup as it now has a +1 priority weight. The tswebextension then checks that this is not a document request and will bypass it.

Expected behavior:

The request to https://data.r.pl/gtm.js?id=GTM-5S6834 should be blocked.

Expected Behavior

No response

Screenshots

Screenshot 1:

Additional Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants