Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export / Import Settings not working correctly #2484

Open
tumatanquang opened this issue Sep 7, 2023 · 2 comments
Open

Export / Import Settings not working correctly #2484

tumatanquang opened this issue Sep 7, 2023 · 2 comments
Assignees

Comments

@tumatanquang
Copy link

tumatanquang commented Sep 7, 2023

AdGuard Extension version

4.2.162

Browser version

Chrome 109

OS version

Windows 7

What filters do you have enabled?

Filter unblocking search ads and self-promotion

What Stealth Mode options do you have enabled?

No response

Issue Details

Context: After installing the extension, default filters include: EasyList + AdGuard English and ABPVN List (Specific Language).

Import Settings

There are 2 problems with this feature:

  1. Will receive An error occurred and restore factory settings if the user does not have internet.

When the user does not have internet (network cable unplugged / disabled, internet access is not available,...) and proceeds to Import settings, it will immediately receive the error message An error occurred then it will delete all current settings data and automatically restore the default settings data.

  1. Enabled filter data in the settings data file is ignored when Import settings:

I have disabled all filters (including the default one):

image

And the settings data file also does not enable any filters:

image

But when Import settings it automatically enable the default filters:

image

It seems to have ignored enabled-filters in case the array was empty (a.k.a no filters enabled).

Export Settings:

If after Import settings (according to case 2) and you do not proceed to disable the default filters again, but directly proceed to Export settings, it will automatically put the above filters in the list of enable filters:

image

The error of Import settings will affect the data of Export settings incorrectly.

Expected Behavior

  1. Can Import settings when the user is not available internet (same as on 4.1 version).
  2. No data is ignored, especially with enabled-filters in case the array is empty (a.k.a no filters are enabled).
  3. Fixing the Import settings error will (probably) resolve the Export settings error.

Screenshots

No response

Additional Information

No response

@tumatanquang
Copy link
Author

Update on version 4.2.189:

Perhaps this is a problem entirely related to the Import settings feature. It will always enable the default filters (EasyList + AdGuard English and ABPVN List (Specific Language)) whether you enable any filters or not.

As above, when I don't enable any filters, it still automatically turns on the default filter.

On version 4.2.189:

  • It is not yet possible to Import settings when internet is not available, the error is similar to that on version 4.2.162.
  • I tried enabling Optional filter, using my Simple filters source. Then I proceed to Export settings. This is the data file that I got from the Export settings.
    It can be seen that (and only) the Optional filter has been enabled:
    Settings data
    But when I Import settings that file, it still automatically enable the default filter!

Stealth mode:

I tried enabling Stealth mode, setting the values of Block third-party cookies and Block first-party cookies (not recommended) to 0 then disabling Block third-party cookies -> Block first-party cookies (not recommended) -> Stealth mode.
Can be seen the data file received from Export settings:

Stealth data

  • stealth-disable-stealth-mode: Stealth mode is disabled.
  • stealth-block-third-party-cookies-time and stealth-block-first-party-cookies-time: Values of Block third-party cookies and Block first-party cookies (not recommended) to 0.

But when I Import settings:

  • Stealth mode will be enabled.
  • The values of Block third-party cookies and Block first-party cookies (not recommended) will automatically reset to default values: 2880 with Block third-party cookies and 4320 with Block first-party cookies (not recommended).

@tumatanquang
Copy link
Author

Update on version 4.2.241: Nothing has changed, still the same as on version 4.2.189!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants