-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export / Import Settings not working correctly #2484
Comments
Update on version 4.2.189:Perhaps this is a problem entirely related to the As above, when I don't enable any filters, it still automatically turns on the default filter. On version 4.2.189:
Stealth mode:I tried enabling
But when I
|
Update on version 4.2.241: Nothing has changed, still the same as on version 4.2.189! |
AdGuard Extension version
4.2.162
Browser version
Chrome 109
OS version
Windows 7
What filters do you have enabled?
Filter unblocking search ads and self-promotion
What Stealth Mode options do you have enabled?
No response
Issue Details
Context: After installing the extension, default filters include: EasyList + AdGuard English and ABPVN List (Specific Language).
Import Settings
There are 2 problems with this feature:
When the user does not have internet (network cable unplugged / disabled, internet access is not available,...) and proceeds to
Import settings
, it will immediately receive the error message An error occurred then it will delete all current settings data and automatically restore the default settings data.Import settings
:I have disabled all filters (including the default one):
And the settings data file also does not enable any filters:
But when
Import settings
it automatically enable the default filters:It seems to have ignored
enabled-filters
in case the array was empty (a.k.a no filters enabled).Export Settings:
If after
Import settings
(according to case 2) and you do not proceed to disable the default filters again, but directly proceed toExport settings
, it will automatically put the above filters in the list of enable filters:The error of
Import settings
will affect the data ofExport settings
incorrectly.Expected Behavior
Import settings
when the user is not available internet (same as on 4.1 version).enabled-filters
in case the array is empty (a.k.a no filters are enabled).Import settings
error will (probably) resolve theExport settings
error.Screenshots
No response
Additional Information
No response
The text was updated successfully, but these errors were encountered: