Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid unblocking rule suggested in the filtering log #2456

Closed
Alex-302 opened this issue Aug 28, 2023 · 0 comments
Closed

Invalid unblocking rule suggested in the filtering log #2456

Alex-302 opened this issue Aug 28, 2023 · 0 comments

Comments

@Alex-302
Copy link
Member

Alex-302 commented Aug 28, 2023

AdGuard Extension version

4.2.159

Browser version

Chrome 116

OS version

Windows 10 x64

What filters do you have enabled?

AdGuard Base filter

What Stealth Mode options do you have enabled?

No response

Issue Details

Steps to reproduce:

  1. Enable AdGuard URL Tracking filter
  2. Open the filtering log and enable preserve log (this is relared to another bug)
  3. Go to https://www.forbes.com/?sh=4ea0b1af2254
  4. Find $removeparam=sh
  5. Try to unblock.

Actual behavior

Filtering log suggests the correct rule in the Patterns @@||forbes.com^$removeparam=sh. But the rule, which will be added, is invalid - @@||forbes.com^$removeparam=sh$domain=forbes.com, because it contains unnecessary and syntactically incorrect part $domain=forbes.com

Screenshot

image

Expected Behavior

@@||forbes.com^$removeparam=sh - like suggested pattern.

Screenshots

No response

Additional Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants