Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass issues #973

Open
RobbieTheWagner opened this issue Dec 9, 2022 · 2 comments
Open

Sass issues #973

RobbieTheWagner opened this issue Dec 9, 2022 · 2 comments

Comments

@RobbieTheWagner
Copy link
Contributor

I am hitting a weird error where if I install ember-table, it breaks PostCSS, unless I install and configure postcss-scss. It would be ideal if we could opt in/out of sass and just get a plain CSS file from ember-table so errors do not occur.

@mixonic
Copy link
Member

mixonic commented Dec 9, 2022

@rwwagner90 hm, on v5.0.0? On that release scss should only be a dev dependency.

The app CSS is plain CSS: https://github.com/Addepar/ember-table/blob/master/addon/styles/addon.css

What is the error you get?

@RobbieTheWagner
Copy link
Contributor Author

@mixonic yeah on 5.0.0. ember-cli-sass is a devDep, yeah, but my guess is because this is an scss file it causes issues https://github.com/Addepar/ember-table/blob/master/app/styles/ember-table/default.scss

When I install ember-table and run ember s I get an error that it can no longer find my CSS I am importing from my app. If I remove ember-table or change my styles/app.css to styles/app.scss and add configure PostCSS to work with scss, things work again.

I believe the issue here is ember-table still requires styles to be scss, even though it does not actually require a dependency on ember-cli-sass anymore.

@mixonic mixonic mentioned this issue Aug 3, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants