Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt-in IE11 / non-modern browser support #800

Closed
ghost opened this issue Jan 3, 2020 · 4 comments
Closed

opt-in IE11 / non-modern browser support #800

ghost opened this issue Jan 3, 2020 · 4 comments

Comments

@ghost
Copy link

ghost commented Jan 3, 2020

While debugging a performance issue, I noticed that ember-table has IE specific checks:
https://github.com/Addepar/ember-table/blob/master/addon/components/ember-table/component.js#L48-L51
ember-useragent imports ua-parser-js which leads to unwanted code in vendor.js.

As a developer who does not need to support IE11, I would like to opt-in for cross-browser support.
It would be nice if these could be eliminated using a macro style approach that prunes unwanted code from the final build.

related issues

#745, #490.

@mixonic
Copy link
Member

mixonic commented Jan 3, 2020

Addepar no longer requires IE11 support so I am amenable to a major release dropping support. Or to some tweaks which make it IE11 support opt-out within 2.x.

It is a little unfortunate to ship a major fairly close to our recent major.

I welcome other perspectives @bantic @frykten @wuarmin or any others.

@ghost
Copy link
Author

ghost commented Jan 3, 2020

It is a little unfortunate to ship a major fairly close to our recent major.

Great point; I did not consider the semantic versioning guarantees. I would then vote for a tweaks approach.

@ctjhoa
Copy link
Contributor

ctjhoa commented Jan 6, 2020

@mixonic Current Ember version still support IE11: emberjs/website#3139 (comment)
As ember-table is part of the ember ecosystem, IMO you should keep IE11 compatibility. I don't see the point of having addons which aren't aligned with their framework.
I completely understand that your company doesn't need it but it's an open source project in a wider ecosystem.

Anyway, if you drop support we'll be forced to fork ember-table.

@mixonic
Copy link
Member

mixonic commented Aug 7, 2020

Please see #819 for a 3.0 plan. 2.x releases of Ember Table will of course continue to exist, however we're moving forward on a 3.0 plan which would mean a 3.0 final release without IE11 support probably some time in September.

@mixonic mixonic closed this as completed Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants