Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ci to python3.11 by default #240

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

RomaricKanyamibwa
Copy link
Contributor

@RomaricKanyamibwa RomaricKanyamibwa commented Jan 26, 2024

Bump all ci jobs to python 3.11 by default and run builds only on python 3.11 and python 3.12

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
Bump all ci jobs to python 3.11 by default, run builds only on python
3.11 and python 3.12 .
Following the bump to python3.11 the pre-commit action fails with the
followin error :
"src/e3/aws/troposphere/iam/policy_statement.py:70:9: B037 Class
`__init__` methods must not return or yield and any values."
This commit fixes that
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a75f956) 83.72% compared to head (8c2a10e) 83.82%.
Report is 16 commits behind head on master.

Files Patch % Lines
src/e3/aws/troposphere/apigateway/__init__.py 97.61% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
+ Coverage   83.72%   83.82%   +0.09%     
==========================================
  Files          47       47              
  Lines        3847     3882      +35     
==========================================
+ Hits         3221     3254      +33     
- Misses        626      628       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomaricKanyamibwa RomaricKanyamibwa merged commit 96fdedf into AdaCore:master Jan 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants