Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Remove automated branch generation for changelogs #529

Merged
merged 7 commits into from
May 27, 2021

Conversation

azlam-abdulsalam
Copy link
Contributor

The last version introduce a feature where changelog used to generate the changelog branch by observing the branch which the artifact is developed from.
This resulted in a bug, which prevents scenario where a single artifact repository is being used along with a scaled trunk model where the packages are
not recreated, resulting in incorrect changelog

To fix these scenarios, we are bringing back the branch flag back and let the users push the changelog to any preferred branch, however one that track
the trunk

The change implies there needs to be a changelog that tracks a branch where the package is originated

Examples:
main --> "changelog-main" (during normal development)
release/1.0 -> "changelog-release_1.0" (when cut a release branch)

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2021

Codecov Report

Merging #529 (7419c70) into develop (e501624) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #529   +/-   ##
========================================
  Coverage    80.01%   80.01%           
========================================
  Files           38       38           
  Lines         1291     1291           
  Branches       226      226           
========================================
  Hits          1033     1033           
  Misses         258      258           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b968db9...7419c70. Read the comment docs.

@azlam-abdulsalam azlam-abdulsalam requested a review from aly76 May 27, 2021 02:58
@azlam-abdulsalam azlam-abdulsalam self-assigned this May 27, 2021
Copy link
Contributor

@aly76 aly76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@azlam-abdulsalam azlam-abdulsalam merged commit 580f0a8 into develop May 27, 2021
@azlam-abdulsalam azlam-abdulsalam deleted the fix/changelog-branch branch May 27, 2021 05:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants