Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Promoted artifacts need to be republished #523

Closed
azlam-abdulsalam opened this issue May 18, 2021 · 1 comment · Fixed by #528
Closed

Promoted artifacts need to be republished #523

azlam-abdulsalam opened this issue May 18, 2021 · 1 comment · Fixed by #528
Assignees
Labels
bug Something isn't working enhancement enhancement to existing feature
Milestone

Comments

@azlam-abdulsalam
Copy link
Contributor

sfpowerscripts in its current design, implies that promoted packages have to be republished (as it internally changes the artifact state to mark it as promoted). This would only work when the user is having two artifact registries.If its a single artifact repo such as npm is used, the package gets rejected, if its already published (say from trunk). This implies that the packages have to be rebuilt when a release branch is cut.

To enable it the following should be done

  • The promote flag should be removed from the internal state
  • Promotion should be moved into the release definition where packages are promoted before deploying to a particular environment
@azlam-abdulsalam azlam-abdulsalam added the bug Something isn't working label May 18, 2021
@azlam-abdulsalam azlam-abdulsalam added this to the Milestone 23 milestone May 18, 2021
@azlam-abdulsalam azlam-abdulsalam linked a pull request May 23, 2021 that will close this issue
@azlam-abdulsalam azlam-abdulsalam added the enhancement enhancement to existing feature label May 24, 2021
@azlam-abdulsalam
Copy link
Contributor Author

Have Raised a PR for fixing this. Release command will have an option to promote packages before installing into an org.
The sequence will be Promote and Install, thus allowing development team to fix only the package that they failed to promote, rather than incrementing all the packages again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement enhancement to existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants