Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Native support for Datadog metrics #505

Merged
merged 3 commits into from
Apr 23, 2021
Merged

Native support for Datadog metrics #505

merged 3 commits into from
Apr 23, 2021

Conversation

azlam-abdulsalam
Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam commented Apr 23, 2021

Fixes #494

Support Datadog natively

  • Uses environment variables SFPOWERSCRIPTS_DATADOG, SFPOWERSCRIPTS_DATADOG_HOST and SFPOWERSCRIPTS_DATADOG_API_KEY to set up the required API integration
    
  • Flush is set to 0, so the metrics are sent immediately, as CI/CD agents could crash and there would be chances, it wont have time to report if using buffered

@azlam-abdulsalam azlam-abdulsalam requested a review from aly76 April 23, 2021 03:50
@codecov-commenter
Copy link

Codecov Report

Merging #505 (06a7971) into develop (0db7480) will decrease coverage by 2.57%.
The diff coverage is 54.54%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #505      +/-   ##
===========================================
- Coverage    81.17%   78.59%   -2.58%     
===========================================
  Files           33       35       +2     
  Lines         1126     1210      +84     
  Branches       200      212      +12     
===========================================
+ Hits           914      951      +37     
- Misses         212      259      +47     
Impacted Files Coverage Δ
...werscripts-cli/src/utils/get18DigitSalesforceId.ts 21.42% <21.42%> (ø)
packages/core/src/utils/SFPStatsSender.ts 35.48% <22.72%> (-20.77%) ⬇️
packages/core/src/package/PackageDiffImpl.ts 92.50% <77.77%> (+0.19%) ⬆️
...rscripts-cli/src/impl/release/ReleaseDefinition.ts 92.85% <92.85%> (ø)
...ckages/sfpowerscripts-cli/src/ProjectValidation.ts 69.23% <93.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa18371...06a7971. Read the comment docs.

@aly76 aly76 changed the title Add option for datadog natively Native support for Datadog metrics Apr 23, 2021
@aly76 aly76 merged commit f9e9a6e into develop Apr 23, 2021
@aly76 aly76 deleted the issue/494 branch April 23, 2021 05:46
@azlam-abdulsalam azlam-abdulsalam added this to the Milestone 22 milestone May 9, 2021
@azlam-abdulsalam azlam-abdulsalam added the enhancement enhancement to existing feature label May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support DataDog Natively
3 participants