Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support fellowship #65

Closed
brenzi opened this issue Dec 1, 2022 · 6 comments · Fixed by #73
Closed

support fellowship #65

brenzi opened this issue Dec 1, 2022 · 6 comments · Fixed by #73

Comments

@brenzi
Copy link
Contributor

brenzi commented Dec 1, 2022

The config file can override council and technical committee members. Would be great if the kusama config could be extended to override the fellowship.
I'd like to test the whitelisted_caller flow for gov2

@ermalkaleci
Copy link
Collaborator

you can add anything into import-storage:

@brenzi
Copy link
Contributor Author

brenzi commented Dec 2, 2022

Could you add an example? Its not clear to me how I would make alice a single member of fellowship

@ermalkaleci
Copy link
Collaborator

Screenshot 2022-12-02 at 10 31 18 AM

check README (Optional) Pre-define/override storage using option --import-storage=storage.[json/yaml]. See example storage below.

it's a double map like Token::Accounts so it will be FellowshipCollective: { Members: }

 FellowshipCollective: {
  Members: [
    [
      ["DSbhnaGBytDGRfZTmdcArzCL6T3HQ8gcZxWpF5gLBP6y1Qe"],
      {
        rank: 3
      }
    ]
  ]
}

@brenzi
Copy link
Contributor Author

brenzi commented Dec 3, 2022

yes, this works. but unlike for council, it does not replace the the onchain fellowship, it just adds an account to it. Certain test scenarios may require to gain a majority of fellowship, so it would be nice if we could purge the fellowship and repalce it entirely

@ermalkaleci
Copy link
Collaborator

because council is storage_value and fellowship is storage_map. if you want to remove something just set null
FellowshipCollective: { Members: [ [ ["DSbhnaGBytDGRfZTmdcArzCL6T3HQ8gcZxWpF5gLBP6y1Qe"], null ] ] }

@xlc
Copy link
Member

xlc commented Dec 5, 2022

I added the ability to clear storage map with #73 and updated kusama config with Alice as the solo fellowship member.
I didn't spend a lot of time testing so it will be great if you can help give it a play and see if it is working as expected @brenzi

@xlc xlc closed this as completed in #73 Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants