Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop RPC to estimate weights by dry run transaction and report used weight #814

Closed
ermalkaleci opened this issue Mar 16, 2021 · 3 comments
Closed

Develop RPC to estimate weights by dry run transaction and report used weight #814

ermalkaleci opened this issue Mar 16, 2021 · 3 comments
Labels
C5-misc T1-feature

Comments

@ermalkaleci
Copy link
Contributor

No description provided.

@xlc
Copy link
Member

xlc commented Mar 16, 2021

Doesn't the RPC from transaction payment does this? https://github.com/paritytech/substrate/blob/master/frame/transaction-payment/rpc/runtime-api/src/lib.rs

@ermalkaleci
Copy link
Contributor Author

@xlc This end up calling get_dispatch_info which returns weight specified in #[pallet::weight]. It doesn't execute anything so no measurement is done here

@xlc
Copy link
Member

xlc commented Mar 17, 2021

In that case paritytech/polkadot-sdk#341 can solve the issue. The extrinsic success / failed event will have actual weight.

@xlc xlc closed this as completed Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C5-misc T1-feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xlc @ermalkaleci @syan095