Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rezbuild.py broken #619

Closed
mottosso opened this issue Apr 26, 2019 · 8 comments
Closed

rezbuild.py broken #619

mottosso opened this issue Apr 26, 2019 · 8 comments

Comments

@mottosso
Copy link
Contributor

Recent commit here broken the use of rezbuild.py.

$ rez build
...
    mod.setup_parser(parser)
  File "c:\users\manima\dropbox\dev\anima\rez2\lib\site-packages\rez-2.29.0-py2.7.egg\rez\cli\build.py", line 97, in setup_parser
    setup_parser_common(parser)
  File "c:\users\manima\dropbox\dev\anima\rez2\lib\site-packages\rez-2.29.0-py2.7.egg\rez\cli\build.py", line 49, in setup_parser_common
    cls_.bind_cli(parser, group)

With the following files.

my_package/
  package.py
  rezbuild.py
@instinct-vfx
Copy link
Contributor

What are you testing this with? Using 2.29.0 i can not reproduce this. At least not with my own packages. Both packages with custom arguments and without build just fine. @lambdaclan

@mottosso
Copy link
Contributor Author

It's recent, from 2.29.1 onwards.

@instinct-vfx
Copy link
Contributor

Sorry, i meant 2.29.1. Seems to work fine for me:
image

@instinct-vfx
Copy link
Contributor

Okay, so this does break, but it only breaks with legacy rezbuild.py setups. I have migrated my packages to using custom build commands instead and that still works.

@RudeyPunk
Copy link

I am having an issue that may be related.

I am a Rez noob, trying to understand how Rez works with Windows; (windows-10.0.17134, Rez v2.29.1). I am trying to do a "rez-build" on the supplied "example-package" and I'm having python problems with the default content:

C:\rez-master\rez-master\example_packages\hello_world>rez-build --install
Traceback (most recent call last):
File "C:\Python27\Lib\runpy.py", line 174, in _run_module_as_main
"main", fname, loader, pkg_name)
File "C:\Python27\Lib\runpy.py", line 72, in run_code
exec code in run_globals
File "C:\Python27amd64\Lib\site-packages\Rez\Scripts\rez\rez-build.exe_main
.py", line 2, in
File "c:\python27amd64\lib\site-packages\rez\lib\site-packages\rez-2.29.1-py2.7.egg\rez\cli_main.py", line 119, in run
opts = parser.parse_args(arg_groups[0])
File "c:\python27amd64\lib\site-packages\rez\lib\site-packages\rez-2.29.1-py2.7.egg\rez\vendor\argparse.py", line 1703, in parse_args
args, argv = self.parse_known_args(args, namespace)
File "c:\python27amd64\lib\site-packages\rez\lib\site-packages\rez-2.29.1-py2.7.egg\rez\vendor\argparse.py", line 1735, in parse_known_args
namespace, args = self._parse_known_args(args, namespace)
File "c:\python27amd64\lib\site-packages\rez\lib\site-packages\rez-2.29.1-py2.7.egg\rez\vendor\argparse.py", line 1923, in _parse_known_args
positionals_end_index = consume_positionals(start_index)
File "c:\python27amd64\lib\site-packages\rez\lib\site-packages\rez-2.29.1-py2.7.egg\rez\vendor\argparse.py", line 1900, in consume_positionals
take_action(action, args)
File "c:\python27amd64\lib\site-packages\rez\lib\site-packages\rez-2.29.1-py2.7.egg\rez\vendor\argparse.py", line 1809, in take_action
action(self, namespace, argument_values, option_string)
File "c:\python27amd64\lib\site-packages\rez\lib\site-packages\rez-2.29.1-py2.7.egg\rez\cli_util.py", line 74, in call
self.setup_subparser(parser_name, parser)
File "c:\python27amd64\lib\site-packages\rez\lib\site-packages\rez-2.29.1-py2.7.egg\rez\cli_util.py", line 80, in setup_subparser
help
= parser.setup_subparser(parser_name, parser)
File "c:\python27amd64\lib\site-packages\rez\lib\site-packages\rez-2.29.1-py2.7.egg\rez\cli_main.py", line 33, in call
mod.setup_parser(parser)
File "c:\python27amd64\lib\site-packages\rez\lib\site-packages\rez-2.29.1-py2.7.egg\rez\cli\build.py", line 97, in setup_parser
setup_parser_common(parser)
File "c:\python27amd64\lib\site-packages\rez\lib\site-packages\rez-2.29.1-py2.7.egg\rez\cli\build.py", line 49, in setup_parser_common
cls
.bind_cli(parser, group)
TypeError: bind_cli() takes exactly 2 arguments (3 given)

I get this exact same behavior if I use "rezbuild.py", "CMakeLists.txt" or just "rez-build -i"
Any kind of help would be be extremely appreciated!

@nerdvegas
Copy link
Contributor

Note that I've fixed this in 2.30.0 just now, apologies for the breakage on master.
@RudeyPunk

@nerdvegas
Copy link
Contributor

@RudeyPunk
Copy link

It's all good,! Thanks Allan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants