Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disambiguate ENV_VAR_REGEX in rex.py / utils/formatting.py #1233

Closed
nerdvegas opened this issue Feb 22, 2022 · 0 comments
Closed

disambiguate ENV_VAR_REGEX in rex.py / utils/formatting.py #1233

nerdvegas opened this issue Feb 22, 2022 · 0 comments

Comments

@nerdvegas
Copy link
Contributor

There are two very similar but separate consts in these sourcefiles.

The instance in formatting.py isn't ideal, it would be better served to match the value in rex.py, and the manual parsing of curly braces can be removed.

These two sourcepaths should probably share the same regex instance. However, we first need to determine if ENV_VAR_REGEX needs to be overridable in shells (see #1199). If it does not, we should remove the class attrib from ActionInterpreter (in rex) altogether and just use ENV_VAR_REGEX imported from formatting.py, to avoid confusion.

@JeanChristopheMorinPerso JeanChristopheMorinPerso closed this as not planned Won't fix, can't repro, duplicate, stale Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants