From 0f97a86349b377e0f380d2782326844bef652820 Mon Sep 17 00:00:00 2001 From: Kimball Thurston Date: Mon, 22 Jul 2019 21:45:39 +1200 Subject: [PATCH] Fix dos files to unix, part of #462 Signed-off-by: Kimball Thurston --- ASWF/tsc-meetings/2019-06-13.md | 180 ++++++++++++++++---------------- ASWF/tsc-meetings/2019-06-27.md | 114 ++++++++++---------- ASWF/tsc-meetings/2019-07-18.md | 166 ++++++++++++++--------------- 3 files changed, 230 insertions(+), 230 deletions(-) mode change 100755 => 100644 ASWF/tsc-meetings/2019-07-18.md diff --git a/ASWF/tsc-meetings/2019-06-13.md b/ASWF/tsc-meetings/2019-06-13.md index 0a5185e02d..169cfa317a 100644 --- a/ASWF/tsc-meetings/2019-06-13.md +++ b/ASWF/tsc-meetings/2019-06-13.md @@ -1,90 +1,90 @@ - -# 6/13/2019 - -### Attending: -* Cary Phillips - ILM -* Larry Gritz - SPI -* Rod Bogart - Epic -* Peter Hillman - Weta -* Kimball Thurston - Weta -* Nick Porcino - Oculus -* Christina Tempelaar-Lietz - Epic -* John Mertic - Linux Foundation - -### Discussion: -* Welcome new TSC members: - * Nick Porcino - Oculus - * Christina Tempelaar-Lietz - Epic - * Kimball Thurston - Weta - * Piotr was invited by hasn’t responded. -* Project goals by SIGGRAPH: - * Reach “adopted” status, seems attainable. - * CII badge progress is at 68% - * Need CI setup - * Need static/dynamic analysis setup - * Need to address security issues/policies - * Put out a new release, version 2.4: - * Address outstanding CVE’s - * Document existing CVE’s - * Compiler warnings - * CMake fixes - * Acknowledge most Issues and PRs; many can be closed as is. - * Proposal/position on the future of Imath; go into the BOF prepared to discuss. -* “Guide to the OpenEXR Project” - * GOVERNANCE.md, CONTRIBUTING.md, etc. - * Clarify project roles and clarify terminology: - * Committer vs. TSC - * Nick Rasmussen is an example of a committer not on the TSC. - * Need to clarify terms of service, how long do TSC members serve. - * OCIO meeting notes designate a PR Reviewer? - * Ad-hoc for that project to ensure fast turn around due to large number of contributions - * May want some form of this to ensure that PRs are reviewed -* Legal: - * Who keeps track of CLA’s on file? - * Should just be part of the process (CLA, DCO checks) - * Old PRs, what to do about obtaining CLAs prior to merge - * Need to check w/ ILM legal just to clarify old copyright / CLA - * Does OCIO have a policy of accepting small fixes without a CLA? No, that’s OIIO. All ASWF/Linux Foundation projects require CLA’s for every PR, no matter how small. -* CII Badge requires “acknowledgment of bug reports”. What should our policy be? - * Standard use of GitHub labels, documented in CONTRIBUTING. - * Use of GitHub Milestones to indicate priority. -* Status of the CII Best Practices Badge: - * Must ensure timely response to posts on openexr-dev - * What does it take to ensure that the website now uses https? - * Security: - * security@openexr.com, info@openexr.com - * John to arrange setting up the forwards to private tsc - * Outstanding CVE’s: - * One has a PR that needs to be merged. - * Other CVE issues have been resolved but the issues were never closed. - * CVE’s should be documented in CHANGES.md. - * OpenEXR needs a designated security expert - * Cryptographic protocols are not applicable. - * Ready to set up Azure? - * Compiler Warning flags - * -Wall with GCC 7/C++17 on Ubuntu gives a handful of warnings, straightforward to fix. - * What about Windows? - * Code coverage, static analysis, dynamic analysis: SonarCloud? - * Just needs to have been done at least prior to release (as opposed to fully integrated to release schedule) - * Test policy adherence? -* Should we update source code copyright notices? - * Cary will check with Lucasfilm Business Affairs. -* What’s the status of moving the github repository? -* TODO’s and action items: - * Label issues and PR’s - * Gives perception of response - * Use milestones instead to mark issues for including in next release - * Need to be more aggressive with closing issues that had a back and forth resulting in a consensus there’s nothing to do - * Standard comment about a house-cleaning event in migration to ASWF - * Merge/act on existing PR’s - * Fix compiler warnings - * SonarCloud: Static and dynamic analysis - * Azure - * Web site/documentation - * JM: Can be moved independently, whenever ready - * CP: wants to re-do web site to make it easier to maintain - * Email addresses for info & security - * Imath white paper - * Christina - will work on SonarCloud - * Kimball - will work on PRs, cmake, compile warnings - * Nick - will review PRs as well + +# 6/13/2019 + +### Attending: +* Cary Phillips - ILM +* Larry Gritz - SPI +* Rod Bogart - Epic +* Peter Hillman - Weta +* Kimball Thurston - Weta +* Nick Porcino - Oculus +* Christina Tempelaar-Lietz - Epic +* John Mertic - Linux Foundation + +### Discussion: +* Welcome new TSC members: + * Nick Porcino - Oculus + * Christina Tempelaar-Lietz - Epic + * Kimball Thurston - Weta + * Piotr was invited by hasn’t responded. +* Project goals by SIGGRAPH: + * Reach “adopted” status, seems attainable. + * CII badge progress is at 68% + * Need CI setup + * Need static/dynamic analysis setup + * Need to address security issues/policies + * Put out a new release, version 2.4: + * Address outstanding CVE’s + * Document existing CVE’s + * Compiler warnings + * CMake fixes + * Acknowledge most Issues and PRs; many can be closed as is. + * Proposal/position on the future of Imath; go into the BOF prepared to discuss. +* “Guide to the OpenEXR Project” + * GOVERNANCE.md, CONTRIBUTING.md, etc. + * Clarify project roles and clarify terminology: + * Committer vs. TSC + * Nick Rasmussen is an example of a committer not on the TSC. + * Need to clarify terms of service, how long do TSC members serve. + * OCIO meeting notes designate a PR Reviewer? + * Ad-hoc for that project to ensure fast turn around due to large number of contributions + * May want some form of this to ensure that PRs are reviewed +* Legal: + * Who keeps track of CLA’s on file? + * Should just be part of the process (CLA, DCO checks) + * Old PRs, what to do about obtaining CLAs prior to merge + * Need to check w/ ILM legal just to clarify old copyright / CLA + * Does OCIO have a policy of accepting small fixes without a CLA? No, that’s OIIO. All ASWF/Linux Foundation projects require CLA’s for every PR, no matter how small. +* CII Badge requires “acknowledgment of bug reports”. What should our policy be? + * Standard use of GitHub labels, documented in CONTRIBUTING. + * Use of GitHub Milestones to indicate priority. +* Status of the CII Best Practices Badge: + * Must ensure timely response to posts on openexr-dev + * What does it take to ensure that the website now uses https? + * Security: + * security@openexr.com, info@openexr.com + * John to arrange setting up the forwards to private tsc + * Outstanding CVE’s: + * One has a PR that needs to be merged. + * Other CVE issues have been resolved but the issues were never closed. + * CVE’s should be documented in CHANGES.md. + * OpenEXR needs a designated security expert + * Cryptographic protocols are not applicable. + * Ready to set up Azure? + * Compiler Warning flags + * -Wall with GCC 7/C++17 on Ubuntu gives a handful of warnings, straightforward to fix. + * What about Windows? + * Code coverage, static analysis, dynamic analysis: SonarCloud? + * Just needs to have been done at least prior to release (as opposed to fully integrated to release schedule) + * Test policy adherence? +* Should we update source code copyright notices? + * Cary will check with Lucasfilm Business Affairs. +* What’s the status of moving the github repository? +* TODO’s and action items: + * Label issues and PR’s + * Gives perception of response + * Use milestones instead to mark issues for including in next release + * Need to be more aggressive with closing issues that had a back and forth resulting in a consensus there’s nothing to do + * Standard comment about a house-cleaning event in migration to ASWF + * Merge/act on existing PR’s + * Fix compiler warnings + * SonarCloud: Static and dynamic analysis + * Azure + * Web site/documentation + * JM: Can be moved independently, whenever ready + * CP: wants to re-do web site to make it easier to maintain + * Email addresses for info & security + * Imath white paper + * Christina - will work on SonarCloud + * Kimball - will work on PRs, cmake, compile warnings + * Nick - will review PRs as well diff --git a/ASWF/tsc-meetings/2019-06-27.md b/ASWF/tsc-meetings/2019-06-27.md index d2726337a0..800a05483e 100644 --- a/ASWF/tsc-meetings/2019-06-27.md +++ b/ASWF/tsc-meetings/2019-06-27.md @@ -1,57 +1,57 @@ -# 6/27/2019 - -### Agenda: -* Clarify the process for approving and merging PR’s -* Release plan: Code freeze Friday, July 12? -* SIGGRAPH BOF agenda -* Update on SonarCloud -* Azure rollout -* Standalone Imath -* Review outstanding PR’s, via Kimball’s [PR spreadsheet](https://docs.google.com/spreadsheets/d/1dwgWs5GWur-BJkYf4J3ChbjMfb5ZlVn7q1QHq9XmB2Y/edit?ts=5d0409a9#gid=0) - -### Attending: - -* Cary Phillips -* Larry Gritz -* Rod Bogart -* Peter Hillman -* Kimball Thurston -* John Mertic -* Nick Porcino -* Christina Tempelaar-Lietz - - -### Discussion: -* Siggraph BOF plan: should we release before? -* July 13-14 should be deadline for release, if we do that (we will shoot for that) -* Need to check tarball versus git clone/build -* Documentation needs to be updated to ensure simple “I want OpenEXR” will just work -* Windows has most of the issues from users trying -* Various README files need to be clear to build lmBase separately from OpenEXR -* Can we deprecate autoconf, and just confirm that cmake works? Needs effort on each platform to check cmake is working -* Let’s delay the split of IlmBase -* To proceed for release (release number TBD): - * Get cmake in place - * Get docs update - * Deal with outstanding CVEs - * Need to close out discussion/issue on any outstanding vulnerability - * Need to close out discussion/issue on any outstanding vulnerability - * * Kimball has been looking at CVEs: pointer math can overflow int32 -* Pull request needs process to merge. Person who submitted can do the merge if they have permission. - * Submit PR - * Somewhen says it looks OK by “Approve” - * Submitter should then perform the Merge - * Issues have been tagged “Needs Info”, we will wait a week or so, then close them out if we hear nothing - * Issues have been tagged “To Do”, those are ready to finish, and we should enlist others to help fix them -* Suggestion: Jonathan Stone might be able to help with Windows cmake issues -* Looking thru issues in spreadsheet - * Issue238 appears to be fixed already - * Issue232 is need work - * Issue351 may be fixed, but Kimball will confirm - * 344 - RGB will try to reach out to Karl Rasche (LinkInd msg sent) - * 251 - Punt for now - * 338 - will check if new release builds on FreeBSD - * 334 - Windows can still have this problem - * Christina testing (file gets generated empty somehow) -* Need change to check the log header files into the repo. Should add unit test to rebuild and compare, but not do build of file during build. -* Will remove issues that refer to old software (ie 281) +# 6/27/2019 + +### Agenda: +* Clarify the process for approving and merging PR’s +* Release plan: Code freeze Friday, July 12? +* SIGGRAPH BOF agenda +* Update on SonarCloud +* Azure rollout +* Standalone Imath +* Review outstanding PR’s, via Kimball’s [PR spreadsheet](https://docs.google.com/spreadsheets/d/1dwgWs5GWur-BJkYf4J3ChbjMfb5ZlVn7q1QHq9XmB2Y/edit?ts=5d0409a9#gid=0) + +### Attending: + +* Cary Phillips +* Larry Gritz +* Rod Bogart +* Peter Hillman +* Kimball Thurston +* John Mertic +* Nick Porcino +* Christina Tempelaar-Lietz + + +### Discussion: +* Siggraph BOF plan: should we release before? +* July 13-14 should be deadline for release, if we do that (we will shoot for that) +* Need to check tarball versus git clone/build +* Documentation needs to be updated to ensure simple “I want OpenEXR” will just work +* Windows has most of the issues from users trying +* Various README files need to be clear to build lmBase separately from OpenEXR +* Can we deprecate autoconf, and just confirm that cmake works? Needs effort on each platform to check cmake is working +* Let’s delay the split of IlmBase +* To proceed for release (release number TBD): + * Get cmake in place + * Get docs update + * Deal with outstanding CVEs + * Need to close out discussion/issue on any outstanding vulnerability + * Need to close out discussion/issue on any outstanding vulnerability + * * Kimball has been looking at CVEs: pointer math can overflow int32 +* Pull request needs process to merge. Person who submitted can do the merge if they have permission. + * Submit PR + * Somewhen says it looks OK by “Approve” + * Submitter should then perform the Merge + * Issues have been tagged “Needs Info”, we will wait a week or so, then close them out if we hear nothing + * Issues have been tagged “To Do”, those are ready to finish, and we should enlist others to help fix them +* Suggestion: Jonathan Stone might be able to help with Windows cmake issues +* Looking thru issues in spreadsheet + * Issue238 appears to be fixed already + * Issue232 is need work + * Issue351 may be fixed, but Kimball will confirm + * 344 - RGB will try to reach out to Karl Rasche (LinkInd msg sent) + * 251 - Punt for now + * 338 - will check if new release builds on FreeBSD + * 334 - Windows can still have this problem + * Christina testing (file gets generated empty somehow) +* Need change to check the log header files into the repo. Should add unit test to rebuild and compare, but not do build of file during build. +* Will remove issues that refer to old software (ie 281) diff --git a/ASWF/tsc-meetings/2019-07-18.md b/ASWF/tsc-meetings/2019-07-18.md old mode 100755 new mode 100644 index e050b1c989..2563a1248b --- a/ASWF/tsc-meetings/2019-07-18.md +++ b/ASWF/tsc-meetings/2019-07-18.md @@ -1,83 +1,83 @@ -# 7/17/2019 - -### Attending: -* Cary Phillips -* Peter Hillman -* Kimball Thurston -* John Mertic -* Christina Tempelaar-Lietz - -### Agenda: -* Repo move -* License scan -* Cmake/autoconf progress -* Azure+Sonar rollout -* SIGGRAPH BoF prep -* Issues needing attention - -### Discussion: - -* Why is GitHub repo name so long? - * John has no idea, would prefer shorter as well - * Is alias possible? - -* Repo move - * John - issues to consider: - * Ideal to have new CLA in place before repo move, in the works - * Have all of your organization sign the CCLA - * Make sure license scan, big critical issues are taking care of first. - * Clean up any proprietary notices. - * So perhaps we will wait - -* License scan - * Cary has made progress on reviewing the full scan. - * Some licenses from Pixar, shouldn’t be an issue to get Pixar to change license or board to buy off on it - * Other things don’t have a license, can we add a license? - * John - good to know how those contributions came in. - * Most is from ILM. - * Display driver renderman, ILM - * Photoshop plugin Piotr - * New git makefiles - question for Nick - * Need more information about what these things are, whether we still need it, the history. - * Should we replace with spdx identifier. - * ONLY an ILM employee should do this, modify ILM related license text. - * Patent on compressions code from Dreamworks? - * By comparison, Apache license has a mechanism for handling issues with patent related issues . - * There may be ambiguities downstream because license language is non-standard. - * Autoconf scripts come with a GNU license, very permissive license. - * How much longer do we want to support autoconf? Until we are certain CMake setup is robust. - * Lots of CMake files with no license information in them. - * “Copyright: OpenEXR project with its contributors” <- specific language is in the CONTRIBUTING.md with the instructions for the copyright line. - -* Cmake/autoconf progress - * Kimball closed many build-related issues. - * Kimball can’t test Windows - needs confirmation that the auto package config works. (some cmake projects have custom package configs for Windows but this may have come from before the auto config existed). - * Xcode generator doesn’t work - bug in CMake - * Are we going to continue using mkdist to make the tarballs? Cary wants to poll the community. - * Cary tried to fix the PyIlmBase autoconf setup. Fails because can’t run test program, Cary has a potential fix. - * Christina to read over the INSTALL instructions. - * Should mention external dependencies and how to override them. e.g.Zlib, Boost, Python. - * Verify in INSTALL instructions that each variable is annotated with descriptive text. - * Target end of week. - -* Azure+Sonar rollout - * Christina to look into whether we should make use of ctest options for publishing test results. There is a placeholder for publishing test results, but the test step doesn’t generate the requisite ctest xml output files yet.. - * Christina will work on making Azure pipeline work with the new CMake setup. - * Windows and mac jobs not working yet, in progress. - * Christina also needs to add IlmFuzzTest as a scheduled job. - -* SIGGRAPH BoF prep - * Present what we are thinking and solicit feedback. - * Kimball can put together some slides based on recent and proposed code changes. - * Cary has a google doc in progress to use at the BoF. - * Warn people that next version will be a 3.x, change the ABI. - * Warn about potentially changing the API as well (no API changes yet). - * Imath changes. So people are aware they may have to change some code. - -* Other - * Discussing remaining CVE, issues.. - * Issue 232 - Kimball has pending PR but only a partial fix. Has a more complete fix planned for integer overflow issue. - * PR 451 - Peter Hillman fixed but would be good to have another person review. - * Issue 344 / PR 445 - Huffman encoding based on tile size - make it optional, off by default. CMake flag to enable better performance? Roll it out with OpenEXR 3 release. - * PR 414 - assigned to Kimball, replaces PR 401. - * Lots of older PRs related to CMake, Kimball has put comments to try new CMake. If no response, will close them. +# 7/17/2019 + +### Attending: +* Cary Phillips +* Peter Hillman +* Kimball Thurston +* John Mertic +* Christina Tempelaar-Lietz + +### Agenda: +* Repo move +* License scan +* Cmake/autoconf progress +* Azure+Sonar rollout +* SIGGRAPH BoF prep +* Issues needing attention + +### Discussion: + +* Why is GitHub repo name so long? + * John has no idea, would prefer shorter as well + * Is alias possible? + +* Repo move + * John - issues to consider: + * Ideal to have new CLA in place before repo move, in the works + * Have all of your organization sign the CCLA + * Make sure license scan, big critical issues are taking care of first. + * Clean up any proprietary notices. + * So perhaps we will wait + +* License scan + * Cary has made progress on reviewing the full scan. + * Some licenses from Pixar, shouldn’t be an issue to get Pixar to change license or board to buy off on it + * Other things don’t have a license, can we add a license? + * John - good to know how those contributions came in. + * Most is from ILM. + * Display driver renderman, ILM + * Photoshop plugin Piotr + * New git makefiles - question for Nick + * Need more information about what these things are, whether we still need it, the history. + * Should we replace with spdx identifier. + * ONLY an ILM employee should do this, modify ILM related license text. + * Patent on compressions code from Dreamworks? + * By comparison, Apache license has a mechanism for handling issues with patent related issues . + * There may be ambiguities downstream because license language is non-standard. + * Autoconf scripts come with a GNU license, very permissive license. + * How much longer do we want to support autoconf? Until we are certain CMake setup is robust. + * Lots of CMake files with no license information in them. + * “Copyright: OpenEXR project with its contributors” <- specific language is in the CONTRIBUTING.md with the instructions for the copyright line. + +* Cmake/autoconf progress + * Kimball closed many build-related issues. + * Kimball can’t test Windows - needs confirmation that the auto package config works. (some cmake projects have custom package configs for Windows but this may have come from before the auto config existed). + * Xcode generator doesn’t work - bug in CMake + * Are we going to continue using mkdist to make the tarballs? Cary wants to poll the community. + * Cary tried to fix the PyIlmBase autoconf setup. Fails because can’t run test program, Cary has a potential fix. + * Christina to read over the INSTALL instructions. + * Should mention external dependencies and how to override them. e.g.Zlib, Boost, Python. + * Verify in INSTALL instructions that each variable is annotated with descriptive text. + * Target end of week. + +* Azure+Sonar rollout + * Christina to look into whether we should make use of ctest options for publishing test results. There is a placeholder for publishing test results, but the test step doesn’t generate the requisite ctest xml output files yet.. + * Christina will work on making Azure pipeline work with the new CMake setup. + * Windows and mac jobs not working yet, in progress. + * Christina also needs to add IlmFuzzTest as a scheduled job. + +* SIGGRAPH BoF prep + * Present what we are thinking and solicit feedback. + * Kimball can put together some slides based on recent and proposed code changes. + * Cary has a google doc in progress to use at the BoF. + * Warn people that next version will be a 3.x, change the ABI. + * Warn about potentially changing the API as well (no API changes yet). + * Imath changes. So people are aware they may have to change some code. + +* Other + * Discussing remaining CVE, issues.. + * Issue 232 - Kimball has pending PR but only a partial fix. Has a more complete fix planned for integer overflow issue. + * PR 451 - Peter Hillman fixed but would be good to have another person review. + * Issue 344 / PR 445 - Huffman encoding based on tile size - make it optional, off by default. CMake flag to enable better performance? Roll it out with OpenEXR 3 release. + * PR 414 - assigned to Kimball, replaces PR 401. + * Lots of older PRs related to CMake, Kimball has put comments to try new CMake. If no response, will close them.