-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Test pass for build artifacts #1027
Comments
I like where you are going with this. Here is some more thoughts I have: General testing good practices:
General improvements to be made for CI:
I have other things in my head but I think it would diverge a little bit from this issue. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature Request
With github actions producing wheels to deliver to pypi, it would be helpful to have a separate part of our build process to validate those exact artifacts before they can become candidates for pypi delivery.
Description
At a minimum, smoke tests could be run that did something simple like:
The testing should be run on target platforms called out as supported.
In a perfect world, the full unittest suite would be run against the wheels that are being delivered.
The main objective of this testing should be to catch packaging issues like:
libopentimelineio
orlibopentime
or missing.so
files for those in the package (whatever the chosen method of including those functions is)_otio
module from the package distributionContext
Over the course of improving our build system setup, the above listed issues have been hallmark things that pop up when iterating on our somewhat brittle combo of cmake configs and
setup.py
. A sanity check that this class of issues hasn't made it into our artifacts will help catch issues close to where they are introduced and increase our confidence when iterating on the build setup.Some things to consider:
The text was updated successfully, but these errors were encountered: