Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Windows build in our CI #1860

Open
lgritz opened this issue Sep 7, 2024 · 3 comments
Open

Set up Windows build in our CI #1860

lgritz opened this issue Sep 7, 2024 · 3 comments
Labels
build / testing / port / CI Affecting the build system, tests, platform support, porting, or continuous integration. Dev Days ASWF Dev Days suitable project good first issue Good one-day project for beginners without much knowledge of the code base help wanted A task that is desired, but needs somebody to commit the effort to implement it. windows Problems specific to MS Windows OS

Comments

@lgritz
Copy link
Collaborator

lgritz commented Sep 7, 2024

Our CI doesn't actually build and test on Windows. This causes no end of despair.

How hard can it be? You don't really need to know anything about OSL internals or even C++ programming. It's mainly about wrangling builds and knowing how such things are done on Windows. Maybe it's even a good Dev Days project?

OpenImageIO's build and CI system is basically the same as OSL's, and it has Windows builds in its CI, so that should provide much of the template (and existence proof) for how this can be done. Probably the hardest part is that unlike OIIO, OSL will need LLVM installed as a dependency.

@lgritz lgritz added build / testing / port / CI Affecting the build system, tests, platform support, porting, or continuous integration. good first issue Good one-day project for beginners without much knowledge of the code base windows Problems specific to MS Windows OS Dev Days ASWF Dev Days suitable project labels Sep 7, 2024
@awesomebil
Copy link

Hello I would like to look into tackling this issue, I am a new developer and would just like to request some clarification. If I understand correctly the current build and install does not work on Windows and the goal is to get it working on Windows? Or am I missing something since it seems like according to the documentation building and testing on Windows should be possible as it is listed as supported although I have not actually tried to build the project on a Windows machine.

@lgritz
Copy link
Collaborator Author

lgritz commented Sep 8, 2024

We know that the software can build and run on Windows. But our project's GHA-based CI does not build and test on Windows. That is what we need to fix.

@lgritz lgritz added the help wanted A task that is desired, but needs somebody to commit the effort to implement it. label Sep 10, 2024
@N8icuss
Copy link

N8icuss commented Nov 19, 2024

Hi I'm currently trying to get osl to build and run on a Windows 10 virtual machine using the instructions that lead to installing with the "build_osl.bat release" command. Is that what you are refering to by GHA-based CI? Anyway I can make a check of anything that deviates from/adds to that set of instructions in order to get it to compile and build osl on Windows 10, if that's what you are wanting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build / testing / port / CI Affecting the build system, tests, platform support, porting, or continuous integration. Dev Days ASWF Dev Days suitable project good first issue Good one-day project for beginners without much knowledge of the code base help wanted A task that is desired, but needs somebody to commit the effort to implement it. windows Problems specific to MS Windows OS
Projects
None yet
Development

No branches or pull requests

3 participants